From 71b4cc4f12963026acb54a0e50040a6f856cb36b Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Wed, 24 Jun 2026 20:55:01 +0530 Subject: [PATCH] refactor: drop dead except TypeError in add_bank_accounts frappe.parse_json never raises TypeError (unlike json.loads on a non-str), so the try/except guarding the parse is now unreachable. --- .../doctype/plaid_settings/plaid_settings.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py index 84ca5cbcff3..ccb9133eb62 100644 --- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py +++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py @@ -80,11 +80,7 @@ def add_institution(token: str, response: str | dict): @frappe.whitelist() def add_bank_accounts(response: str | dict, bank: str | dict, company: str): - try: - response = frappe.parse_json(response) - except TypeError: - pass - + response = frappe.parse_json(response) bank = frappe.parse_json(bank) result = []