nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-03 12:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: evaluate conditions outside loop

Browse Source
This commit is contained in:
Sagar Vora
2025-04-23 21:10:42 +05:30
parent af283d0d9e
commit 7131396ac0
1 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
erpnext/accounts/report/general_ledger/general_ledger.py
View File

@@ -398,27 +398,29 @@ def get_data_with_opening_closing(filters, account_details, accounting_dimension
add_total_to_data(totals, "opening") add_total_to_data(totals, "opening")
if filters.get("group_by") != "Group by Voucher (Consolidated)": if filters.get("group_by") != "Group by Voucher (Consolidated)":
for _acc, acc_dict in gle_map.items(): set_opening_closing = (not filters.get("group_by") and not filters.get("voucher_no")) or (
# acc filters.get("group_by") and filters.get("group_by") != "Group by Voucher"
if acc_dict.entries: )
# opening set_total = filters.get("group_by") or not filters.voucher_no
data.append({"debit_in_transaction_currency": None, "credit_in_transaction_currency": None})
if (not filters.get("group_by") and not filters.get("voucher_no")) or (
filters.get("group_by") and filters.get("group_by") != "Group by Voucher"
):
add_total_to_data(acc_dict.totals, "opening")
data += acc_dict.entries for acc_dict in gle_map.values():
if not acc_dict.entries:
continue
# totals # opening
if filters.get("group_by") or not filters.voucher_no: data.append({"debit_in_transaction_currency": None, "credit_in_transaction_currency": None})
add_total_to_data(acc_dict.totals, "total") if set_opening_closing:
add_total_to_data(acc_dict.totals, "opening")
# closing data += acc_dict.entries
if (not filters.get("group_by") and not filters.get("voucher_no")) or (
filters.get("group_by") and filters.get("group_by") != "Group by Voucher" # totals
): if set_total:
add_total_to_data(acc_dict.totals, "closing") add_total_to_data(acc_dict.totals, "total")
# closing
if set_opening_closing:
add_total_to_data(acc_dict.totals, "closing")
data.append({"debit_in_transaction_currency": None, "credit_in_transaction_currency": None}) data.append({"debit_in_transaction_currency": None, "credit_in_transaction_currency": None})
else: else: