nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-02 16:13:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: add type hints to controller functions

Browse Source
This commit is contained in:
khushi8112
2026-02-20 13:08:52 +05:30
parent 63defa40cb
commit 7100d61f3c
9 changed files with 101 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
erpnext/controllers/accounts_controller.py
View File

@@ -13,6 +13,7 @@ from frappe.query_builder import Criterion, DocType
from frappe.query_builder.custom import ConstantColumn
from frappe.query_builder.functions import Abs, Sum
from frappe.utils import (
DateTimeLikeObject,
add_days,
add_months,
cint,
@@ -3113,12 +3114,14 @@ class AccountsController(TransactionBase):
@frappe.whitelist()
def get_tax_rate(account_head):
def get_tax_rate(account_head: str):
return frappe.get_cached_value("Account", account_head, ["tax_rate", "account_name"], as_dict=True)
@frappe.whitelist()
def get_default_taxes_and_charges(master_doctype, tax_template=None, company=None):
def get_default_taxes_and_charges(
master_doctype: str, tax_template: str | None = None, company: str | None = None
):
if not company:
return {}
@@ -3136,7 +3139,7 @@ def get_default_taxes_and_charges(master_doctype, tax_template=None, company=Non
@frappe.whitelist()
def get_taxes_and_charges(master_doctype, master_name):
def get_taxes_and_charges(master_doctype: str, master_name: str):
if not master_name:
return
from frappe.model import child_table_fields, default_fields
@@ -3548,7 +3551,11 @@ def update_invoice_status():
@frappe.whitelist()
def get_payment_terms(
terms_template, posting_date=None, grand_total=None, base_grand_total=None, bill_date=None
terms_template: str,
posting_date: DateTimeLikeObject | None = None,
grand_total: float | None = None,
base_grand_total: float | None = None,
bill_date: DateTimeLikeObject | None = None,
):
if not terms_template:
return
@@ -3565,7 +3572,11 @@ def get_payment_terms(
@frappe.whitelist()
def get_payment_term_details(
term, posting_date=None, grand_total=None, base_grand_total=None, bill_date=None
term: str | frappe._dict,
posting_date: DateTimeLikeObject | None = None,
grand_total: float | None = None,
base_grand_total: float | None = None,
bill_date: DateTimeLikeObject | None = None,
):
term_details = frappe._dict()
if isinstance(term, str):
@@ -3820,7 +3831,9 @@ def validate_and_delete_children(parent, data, ordered_item=None) -> bool:
@frappe.whitelist()
def update_child_qty_rate(parent_doctype, trans_items, parent_doctype_name, child_docname="items"):
def update_child_qty_rate(
parent_doctype: str, trans_items: str, parent_doctype_name: str, child_docname: str = "items"
):
from erpnext.buying.doctype.supplier_quotation.supplier_quotation import get_purchased_items
from erpnext.selling.doctype.quotation.quotation import get_ordered_items
@@ -4292,7 +4305,7 @@ def update_gl_dict_with_app_based_fields(doc, gl_dict):
@frappe.whitelist()
def get_missing_company_details(doctype, docname):
def get_missing_company_details(doctype: str, docname: str):
from frappe.contacts.doctype.address.address import get_address_display_list
company = frappe.db.get_value(doctype, docname, "company")
@@ -4348,7 +4361,7 @@ def get_missing_company_details(doctype, docname):
@frappe.whitelist()
def update_company_master_and_address(current_doctype, name, company, details):
def update_company_master_and_address(current_doctype: str, name: str, company: str, details: dict | str):
from frappe.utils import validate_email_address
if isinstance(details, str):