From 119904e44f00faa3559ea03ecad601cf99ba8643 Mon Sep 17 00:00:00 2001 From: Ernesto Ruiz Date: Sat, 2 Aug 2025 13:29:33 -0600 Subject: [PATCH 1/3] chore: add translation function on remarks in make_journal_entry in asset.py --- erpnext/assets/doctype/asset/asset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/assets/doctype/asset/asset.py b/erpnext/assets/doctype/asset/asset.py index 291f4309d85..886c3cca41a 100644 --- a/erpnext/assets/doctype/asset/asset.py +++ b/erpnext/assets/doctype/asset/asset.py @@ -1106,7 +1106,7 @@ def make_journal_entry(asset_name): je.voucher_type = "Depreciation Entry" je.naming_series = depreciation_series je.company = asset.company - je.remark = f"Depreciation Entry against asset {asset_name}" + je.remark = _("Depreciation Entry against asset {0}").format(asset_name) je.append( "accounts", From 803180d5de68bf53d717c2375e0edcd5b508c99b Mon Sep 17 00:00:00 2001 From: Ernesto Ruiz Date: Sat, 2 Aug 2025 13:43:18 -0600 Subject: [PATCH 2/3] chore: add translation function on remark in setup_journal_entry_metadata in depreciation.py --- erpnext/assets/doctype/asset/depreciation.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/assets/doctype/asset/depreciation.py b/erpnext/assets/doctype/asset/depreciation.py index a4aaa25b88a..d53cbece1d7 100644 --- a/erpnext/assets/doctype/asset/depreciation.py +++ b/erpnext/assets/doctype/asset/depreciation.py @@ -249,7 +249,9 @@ def setup_journal_entry_metadata(je, depr_schedule_doc, depr_series, depr_schedu je.posting_date = depr_schedule.schedule_date je.company = asset.company je.finance_book = depr_schedule_doc.finance_book - je.remark = f"Depreciation Entry against {asset.name} worth {depr_schedule.depreciation_amount}" + je.remark = _("Depreciation Entry against {0} worth {1}".format( + asset.name, depr_schedule.depreciation_amount + ) def get_credit_and_debit_entry( From a60db40fd2d97863168fc8df815a60a36299f8cd Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Tue, 5 Aug 2025 12:50:33 +0530 Subject: [PATCH 3/3] fix: add missing parentheses --- erpnext/assets/doctype/asset/depreciation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/assets/doctype/asset/depreciation.py b/erpnext/assets/doctype/asset/depreciation.py index d53cbece1d7..f1aceb5cbf9 100644 --- a/erpnext/assets/doctype/asset/depreciation.py +++ b/erpnext/assets/doctype/asset/depreciation.py @@ -249,7 +249,7 @@ def setup_journal_entry_metadata(je, depr_schedule_doc, depr_series, depr_schedu je.posting_date = depr_schedule.schedule_date je.company = asset.company je.finance_book = depr_schedule_doc.finance_book - je.remark = _("Depreciation Entry against {0} worth {1}".format( + je.remark = _("Depreciation Entry against {0} worth {1}").format( asset.name, depr_schedule.depreciation_amount )