nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-03 12:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add remarks to sales invoice

Browse Source
This commit is contained in:
Smit Vora
2020-11-19 18:42:39 +05:30
parent d920f9da59
commit 707b630851
3 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -4,7 +4,7 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe, erpnext import frappe, erpnext
import frappe.defaults import frappe.defaults
from frappe.utils import cint, flt, add_months, today, date_diff, getdate, add_days, cstr, nowdate from frappe.utils import cint, flt, add_months, today, date_diff, getdate, add_days, cstr, nowdate, formatdate
from frappe import _, msgprint, throw from frappe import _, msgprint, throw
from erpnext.accounts.party import get_party_account, get_due_date from erpnext.accounts.party import get_party_account, get_due_date
from erpnext.controllers.stock_controller import update_gl_entries_after from erpnext.controllers.stock_controller import update_gl_entries_after
@@ -530,7 +530,12 @@ class SalesInvoice(SellingController):
self.against_income_account = ','.join(against_acc) self.against_income_account = ','.join(against_acc)
def add_remarks(self): def add_remarks(self):
if not self.remarks: self.remarks = 'No Remarks' if not self.remarks:
if self.po_no and self.po_date:
self.remarks = _("Against Customer Order {0} dated {1}").format(self.po_no,
formatdate(self.po_date))
else:
self.remarks = _("No Remarks")
def validate_auto_set_posting_time(self): def validate_auto_set_posting_time(self):
# Don't auto set the posting date and time if invoice is amended # Don't auto set the posting date and time if invoice is amended

1
erpnext/patches.txt
View File

@@ -678,3 +678,4 @@ erpnext.patches.v12_0.update_state_code_for_daman_and_diu
erpnext.patches.v12_0.rename_lost_reason_detail erpnext.patches.v12_0.rename_lost_reason_detail
erpnext.patches.v12_0.update_leave_application_status erpnext.patches.v12_0.update_leave_application_status
erpnext.patches.v12_0.update_payment_entry_status erpnext.patches.v12_0.update_payment_entry_status
erpnext.patches.v12_0.update_sales_invoice_remarks

35
erpnext/patches/v12_0/update_sales_invoice_remarks.py Normal file
View File

@@ -0,0 +1,35 @@
from __future__ import unicode_literals
from mmap import PAGESIZE
import frappe
from frappe import _
from frappe.utils import formatdate
def execute():
si_list = frappe.db.get_all('Sales Invoice', filters = {
'docstatus': 1,
'remarks': 'No Remarks',
'po_no' : ['!=', ''],
'po_date' : ['!=', '']
},
fields = ['name', 'po_no', 'po_date']
)
for doc in si_list:
remarks = _("Against Customer Order {0} dated {1}").format(doc.po_no,
formatdate(doc.po_date))
frappe.db.set_value('Sales Invoice', doc.name, 'remarks', remarks)
gl_entry_list = frappe.db.get_all('GL Entry', filters = {
'voucher_type': 'Sales Invoice',
'remarks': 'No Remarks',
'voucher_no' : doc.name
},
fields = ['name']
)
for entry in gl_entry_list:
frappe.db.set_value('GL Entry', entry.name, 'remarks', remarks)