From 7abaaed9577250f133114bcfcc91a218c3e9338b Mon Sep 17 00:00:00 2001 From: Abdeali Chharchhoda Date: Mon, 12 Jan 2026 00:23:02 +0530 Subject: [PATCH 1/3] refactor: remove redundant onload function for bank mapping table (cherry picked from commit 7c7ba0154a3c9947e75ef7c8ba35403670bc287f) --- erpnext/accounts/doctype/bank/bank.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/erpnext/accounts/doctype/bank/bank.js b/erpnext/accounts/doctype/bank/bank.js index 77af313dc16..9181b6576d3 100644 --- a/erpnext/accounts/doctype/bank/bank.js +++ b/erpnext/accounts/doctype/bank/bank.js @@ -3,9 +3,6 @@ frappe.provide("erpnext.integrations"); frappe.ui.form.on("Bank", { - onload: function (frm) { - add_fields_to_mapping_table(frm); - }, refresh: function (frm) { add_fields_to_mapping_table(frm); frm.toggle_display(["address_html", "contact_html"], !frm.doc.__islocal); From 22a8d483e10026846df3774c8dee3b14bf185b5f Mon Sep 17 00:00:00 2001 From: Abdeali Chharchhoda Date: Mon, 12 Jan 2026 00:30:11 +0530 Subject: [PATCH 2/3] fix: handle undefined bank_transaction_mapping in quick entry (cherry picked from commit 8a1b8259bdf709fcfa72f71e7779cfd11c054adb) --- erpnext/accounts/doctype/bank/bank.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/erpnext/accounts/doctype/bank/bank.js b/erpnext/accounts/doctype/bank/bank.js index 9181b6576d3..12cde75324d 100644 --- a/erpnext/accounts/doctype/bank/bank.js +++ b/erpnext/accounts/doctype/bank/bank.js @@ -34,11 +34,11 @@ let add_fields_to_mapping_table = function (frm) { }); }); - frm.fields_dict.bank_transaction_mapping.grid.update_docfield_property( - "bank_transaction_field", - "options", - options - ); + const grid = frm.fields_dict.bank_transaction_mapping?.grid; + + if (grid) { + grid.update_docfield_property("bank_transaction_field", "options", options); + } }; erpnext.integrations.refreshPlaidLink = class refreshPlaidLink { From 9a175757ac9ad28ca9538b17213a6e66ed0936aa Mon Sep 17 00:00:00 2001 From: Abdeali Chharchhoda Date: Sat, 24 Jan 2026 11:34:34 +0530 Subject: [PATCH 3/3] refactor: use console.error for error logging in Plaid integration (cherry picked from commit 9322095786bdd3762f47f8cb33f7aae8a5e3b951) --- erpnext/accounts/doctype/bank/bank.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/bank/bank.js b/erpnext/accounts/doctype/bank/bank.js index 12cde75324d..0a268aa88a2 100644 --- a/erpnext/accounts/doctype/bank/bank.js +++ b/erpnext/accounts/doctype/bank/bank.js @@ -113,7 +113,7 @@ erpnext.integrations.refreshPlaidLink = class refreshPlaidLink { "There was an issue connecting to Plaid's authentication server. Check browser console for more information" ) ); - console.log(error); + console.error(error); } plaid_success(token, response) {