nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-18 19:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard scio row lookup in stock entry items_add

Browse Source 
check the result of find() before reading t_warehouse off it. on a
'receive from customer' entry with no row carrying scio_detail, find()
returns undefined and items_add throws a typeerror.

the throw rejects the serially-run handler chain, so the stock entry
controller's own items_add never runs and the new row silently loses
its target warehouse, expense account, cost center and serial/batch
field defaults.

leave t_warehouse unset when no reference row exists, so the rest of
the chain still runs.
This commit is contained in:
pandiyan
2026-07-29 23:12:45 +05:30
parent f71946def7
commit 6e444a1832
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/stock/doctype/stock_entry/stock_entry.js
View File

@@ -997,7 +997,10 @@ frappe.ui.form.on("Stock Entry Detail", {
} }
if (frm.doc.purpose === "Receive from Customer") { if (frm.doc.purpose === "Receive from Customer") {
item.t_warehouse = frm.doc.items.find((item) => item.scio_detail).t_warehouse; const scio_row = frm.doc.items.find((row) => row.scio_detail);
if (scio_row) {
item.t_warehouse = scio_row.t_warehouse;
}
} }
}, },
set_basic_rate_manually(frm, cdt, cdn) { set_basic_rate_manually(frm, cdt, cdn) {