Merge pull request #49935 from rohitwaghchaure/fixed-old-serial-nos-filter

refactor: old serial nos filter
This commit is contained in:
rohitwaghchaure
2025-10-07 15:21:33 +05:30
committed by GitHub
2 changed files with 5 additions and 28 deletions

View File

@@ -613,11 +613,13 @@ class SerialNoValuation(DeprecatedSerialNoValuation):
else:
self.serial_no_incoming_rate = defaultdict(float)
self.stock_value_change = 0.0
self.old_serial_nos = []
serial_nos = self.get_serial_nos()
for serial_no in serial_nos:
incoming_rate = self.get_incoming_rate_from_bundle(serial_no)
if incoming_rate is None:
self.old_serial_nos.append(serial_no)
continue
self.stock_value_change += incoming_rate