nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-21 22:19:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor bugfix (#15210)

Browse Source 
* Minor bugfix

Bugfix for https://github.com/frappe/erpnext/pull/15170

* Update project.py
This commit is contained in:
Benji
2018-09-05 15:54:53 +08:00
committed by Nabin Hait
parent 5122a8e0d7
commit 6c9a92671b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/projects/doctype/project/project.py
View File

@@ -86,7 +86,7 @@ class Project(Document):
def validate_weights(self): def validate_weights(self):
for task in self.tasks: for task in self.tasks:
if task.task_weight is not None: if task.task_weight is not None:
if task.task_weight > 0: if task.task_weight < 0:
frappe.throw(_("Task weight cannot be negative")) frappe.throw(_("Task weight cannot be negative"))
def sync_tasks(self): def sync_tasks(self):
@@ -208,7 +208,7 @@ class Project(Document):
project=%s""", self.name, as_dict=1) project=%s""", self.name, as_dict=1)
pct_complete = 0 pct_complete = 0
for row in weighted_progress: for row in weighted_progress:
pct_complete += row["progress"] * row["task_weight"] / weight_sum pct_complete += row["progress"] * frappe.utils.safe_div(row["task_weight"], weight_sum)
self.percent_complete = flt(flt(pct_complete), 2) self.percent_complete = flt(flt(pct_complete), 2)
if self.percent_complete == 100: if self.percent_complete == 100:
self.status = "Completed" self.status = "Completed"