diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js index 9711c4637bc..be876727314 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js @@ -117,10 +117,10 @@ erpnext.accounts.SalesInvoiceController = class SalesInvoiceController extends ( return item.delivery_note ? true : false; }); - if (!from_delivery_note && !is_delivered_by_supplier) { - cur_frm.add_custom_button( - __("Delivery"), - cur_frm.cscript["Make Delivery Note"], + if (!is_delivered_by_supplier) { + this.frm.add_custom_button( + __("Delivery Note"), + this.frm.cscript["Make Delivery Note"], __("Create") ); } diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py index 9e15f8701bb..c202b70dc42 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py @@ -2211,7 +2211,7 @@ def make_delivery_note(source_name, target_doc=None): "cost_center": "cost_center", }, "postprocess": update_item, - "condition": lambda doc: doc.delivered_by_supplier != 1, + "condition": lambda doc: doc.delivered_by_supplier != 1 and not doc.dn_detail, }, "Sales Taxes and Charges": {"doctype": "Sales Taxes and Charges", "reset_value": True}, "Sales Team": {