nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 08:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: optimize merge GLE

Browse Source 
- Order fields such that comparison will fail faster
- Break out of loops if not matched
This commit is contained in:
Ankush Menat
2021-07-31 20:32:33 +05:30
parent 94396d67a3
commit 6b333a780d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/accounts/general_ledger.py
View File

@@ -100,8 +100,8 @@ def merge_similar_entries(gl_map, precision=None):
return merged_gl_map return merged_gl_map
def check_if_in_list(gle, gl_map, dimensions=None): def check_if_in_list(gle, gl_map, dimensions=None):
account_head_fieldnames = ['party_type', 'party', 'against_voucher', 'against_voucher_type', account_head_fieldnames = ['voucher_detail_no', 'party', 'against_voucher',
'cost_center', 'project', 'voucher_detail_no'] 'cost_center', 'against_voucher_type', 'party_type', 'project']
if dimensions: if dimensions:
account_head_fieldnames = account_head_fieldnames + dimensions account_head_fieldnames = account_head_fieldnames + dimensions
@@ -110,10 +110,12 @@ def check_if_in_list(gle, gl_map, dimensions=None):
same_head = True same_head = True
if e.account != gle.account: if e.account != gle.account:
same_head = False same_head = False
continue
for fieldname in account_head_fieldnames: for fieldname in account_head_fieldnames:
if cstr(e.get(fieldname)) != cstr(gle.get(fieldname)): if cstr(e.get(fieldname)) != cstr(gle.get(fieldname)):
same_head = False same_head = False
break
if same_head: if same_head:
return e return e