nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-26 01:58:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: wrong display_depends_on condition for item group and brand child tables

Browse Source 
(cherry picked from commit de2843d9f1)
This commit is contained in:
Shllokkk
2026-02-17 12:28:15 +05:30
committed by Mergify
parent a8f21dbc07
commit 6ae1b18616
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/pricing_rule/pricing_rule.json
View File

@@ -121,7 +121,7 @@
"in_list_view": 1, "in_list_view": 1,
"in_standard_filter": 1, "in_standard_filter": 1,
"label": "Apply On", "label": "Apply On",
"options": "\nItem Code\nItem Group\nBrand\nTransaction", "options": "Item Code\nItem Group\nBrand\nTransaction",
"reqd": 1 "reqd": 1
}, },
{ {
@@ -657,7 +657,7 @@
"icon": "fa fa-gift", "icon": "fa fa-gift",
"idx": 1, "idx": 1,
"links": [], "links": [],
"modified": "2025-08-20 11:40:07.096854", "modified": "2026-02-17 12:24:07.553505",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Pricing Rule", "name": "Pricing Rule",
@@ -714,9 +714,10 @@
"write": 1 "write": 1
} }
], ],
"row_format": "Dynamic",
"show_name_in_global_search": 1, "show_name_in_global_search": 1,
"sort_field": "creation", "sort_field": "creation",
"sort_order": "DESC", "sort_order": "DESC",
"states": [], "states": [],
"title_field": "title" "title_field": "title"
} }

2
erpnext/accounts/doctype/pricing_rule/pricing_rule.py
View File

@@ -45,7 +45,7 @@ class PricingRule(Document):
apply_discount_on: DF.Literal["Grand Total", "Net Total"] apply_discount_on: DF.Literal["Grand Total", "Net Total"]
apply_discount_on_rate: DF.Check apply_discount_on_rate: DF.Check
apply_multiple_pricing_rules: DF.Check apply_multiple_pricing_rules: DF.Check
apply_on: DF.Literal["", "Item Code", "Item Group", "Brand", "Transaction"] apply_on: DF.Literal["Item Code", "Item Group", "Brand", "Transaction"]
apply_recursion_over: DF.Float apply_recursion_over: DF.Float
apply_rule_on_other: DF.Literal["", "Item Code", "Item Group", "Brand"] apply_rule_on_other: DF.Literal["", "Item Code", "Item Group", "Brand"]
brands: DF.Table[PricingRuleBrand] brands: DF.Table[PricingRuleBrand]

7
erpnext/accounts/doctype/pricing_rule_brand/pricing_rule_brand.json
View File

@@ -10,7 +10,7 @@
], ],
"fields": [ "fields": [
{ {
"depends_on": "eval:parent.apply_on == 'Item Code'", "depends_on": "eval:parent.apply_on == 'Brand'",
"fieldname": "brand", "fieldname": "brand",
"fieldtype": "Link", "fieldtype": "Link",
"in_list_view": 1, "in_list_view": 1,
@@ -28,14 +28,15 @@
], ],
"istable": 1, "istable": 1,
"links": [], "links": [],
"modified": "2024-03-27 13:10:17.857046", "modified": "2026-02-17 12:17:13.073587",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Pricing Rule Brand", "name": "Pricing Rule Brand",
"owner": "Administrator", "owner": "Administrator",
"permissions": [], "permissions": [],
"row_format": "Dynamic",
"sort_field": "creation", "sort_field": "creation",
"sort_order": "DESC", "sort_order": "DESC",
"states": [], "states": [],
"track_changes": 1 "track_changes": 1
} }

7
erpnext/accounts/doctype/pricing_rule_item_group/pricing_rule_item_group.json
View File

@@ -10,7 +10,7 @@
], ],
"fields": [ "fields": [
{ {
"depends_on": "eval:parent.apply_on == 'Item Code'", "depends_on": "eval:parent.apply_on == 'Item Group'",
"fieldname": "item_group", "fieldname": "item_group",
"fieldtype": "Link", "fieldtype": "Link",
"in_list_view": 1, "in_list_view": 1,
@@ -28,14 +28,15 @@
], ],
"istable": 1, "istable": 1,
"links": [], "links": [],
"modified": "2024-03-27 13:10:18.221095", "modified": "2026-02-17 12:16:57.778471",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Pricing Rule Item Group", "name": "Pricing Rule Item Group",
"owner": "Administrator", "owner": "Administrator",
"permissions": [], "permissions": [],
"row_format": "Dynamic",
"sort_field": "creation", "sort_field": "creation",
"sort_order": "DESC", "sort_order": "DESC",
"states": [], "states": [],
"track_changes": 1 "track_changes": 1
} }