From 69ae2661d29206fd3f1744f08afee21178b89dae Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 28 Mar 2022 10:35:32 +0530 Subject: [PATCH] fix: update picked qty on cancellation --- erpnext/stock/doctype/pick_list/pick_list.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/erpnext/stock/doctype/pick_list/pick_list.py b/erpnext/stock/doctype/pick_list/pick_list.py index 3a496866cf1..35cbc2fd858 100644 --- a/erpnext/stock/doctype/pick_list/pick_list.py +++ b/erpnext/stock/doctype/pick_list/pick_list.py @@ -54,9 +54,9 @@ class PickList(Document): def before_cancel(self): #update picked_qty in SO Item on cancel of PL - for location in self.get('locations'): - if location.sales_order_item: - self.update_so(location.sales_order_item,0,location.item_code) + for item in self.get('locations'): + if item.sales_order_item: + self.update_so(item.sales_order_item, -1 * item.picked_qty, item.item_code) def update_so(self,so_item,picked_qty,item_code): so_doc = frappe.get_doc("Sales Order",frappe.db.get_value("Sales Order Item",so_item,"parent")) @@ -637,4 +637,4 @@ def update_common_item_properties(item, location): item.material_request = location.material_request item.serial_no = location.serial_no item.batch_no = location.batch_no - item.material_request_item = location.material_request_item \ No newline at end of file + item.material_request_item = location.material_request_item