nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-17 18:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: zero pre-committed actuals in Budget Variance report tests

Browse Source
This commit is contained in:
Nabin Hait
2026-07-02 12:46:53 +05:30
parent 5f83887334
commit 694328aab6
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/accounts/report/budget_variance_report/test_budget_variance_report.py
View File

@@ -4,7 +4,7 @@
import frappe import frappe
from frappe.utils import nowdate from frappe.utils import nowdate
from erpnext.accounts.doctype.budget.test_budget import make_budget from erpnext.accounts.doctype.budget.test_budget import make_budget, set_total_expense_zero
from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
from erpnext.accounts.report.budget_variance_report.budget_variance_report import execute from erpnext.accounts.report.budget_variance_report.budget_variance_report import execute
from erpnext.accounts.utils import get_fiscal_year from erpnext.accounts.utils import get_fiscal_year
@@ -33,7 +33,12 @@ class TestBudgetVarianceReport(ERPNextTestSuite):
return execute(filters)[1] return execute(filters)[1]
def report_row(self, data, dimension, account=ACCOUNT): def report_row(self, data, dimension, account=ACCOUNT):
return next(row for row in data if row["budget_against"] == dimension and row["account"] == account) row = next(
(r for r in data if r["budget_against"] == dimension and r["account"] == account),
None,
)
self.assertIsNotNone(row, f"No report row for {dimension} / {account}")
return row
def field(self, label): def field(self, label):
return frappe.scrub(f"{label} {self.fy}") return frappe.scrub(f"{label} {self.fy}")
@@ -55,6 +60,8 @@ class TestBudgetVarianceReport(ERPNextTestSuite):
self.assertTrue(columns) self.assertTrue(columns)
def test_budget_amount_shown_with_zero_actual(self): def test_budget_amount_shown_with_zero_actual(self):
# neutralise any committed actuals so the exact Actual/Variance assertions hold
set_total_expense_zero(nowdate(), "cost_center")
make_budget( make_budget(
budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1 budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1
) )
@@ -65,6 +72,9 @@ class TestBudgetVarianceReport(ERPNextTestSuite):
self.assertEqual(row[self.field("Variance")], 120000) self.assertEqual(row[self.field("Variance")], 120000)
def test_actual_expense_updates_actual_and_variance(self): def test_actual_expense_updates_actual_and_variance(self):
# zero out pre-committed actuals: keeps Actual exact and avoids the budget's
# "Stop" action rejecting the journal entry when prior actuals already exist
set_total_expense_zero(nowdate(), "cost_center")
make_budget( make_budget(
budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1 budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1
) )
@@ -88,6 +98,8 @@ class TestBudgetVarianceReport(ERPNextTestSuite):
self.assertEqual(dimensions, {COST_CENTER}) self.assertEqual(dimensions, {COST_CENTER})
def test_monthly_period_totals(self): def test_monthly_period_totals(self):
# zero out pre-committed actuals so total_actual reflects only this test's entry
set_total_expense_zero(nowdate(), "cost_center")
make_budget( make_budget(
budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1 budget_against="Cost Center", cost_center=COST_CENTER, budget_amount=120000, submit_budget=1
) )