From 6878f40d1df268fd179d7c5558e858387b27ae0a Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Sun, 8 Jan 2023 12:01:58 +0530 Subject: [PATCH] chore: add row-index in error msgs --- erpnext/controllers/subcontracting_controller.py | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/erpnext/controllers/subcontracting_controller.py b/erpnext/controllers/subcontracting_controller.py index 335d92f43f3..a588847ad5c 100644 --- a/erpnext/controllers/subcontracting_controller.py +++ b/erpnext/controllers/subcontracting_controller.py @@ -74,24 +74,19 @@ class SubcontractingController(StockController): ) if not is_stock_item: - msg = f"Item {item.item_name} must be a stock item." - frappe.throw(_(msg)) + frappe.throw(_(f"Row {item.idx}: Item {item.item_name} must be a stock item.")) if not is_sub_contracted_item: - msg = f"Item {item.item_name} must be a subcontracted item." - frappe.throw(_(msg)) + frappe.throw(_(f"Row {item.idx}: Item {item.item_name} must be a subcontracted item.")) if item.bom: bom = frappe.get_doc("BOM", item.bom) if not bom.is_active: - msg = f"Please select an active BOM for Item {item.item_name}." - frappe.throw(_(msg)) + frappe.throw(_(f"Row {item.idx}: Please select an active BOM for Item {item.item_name}.")) if bom.item != item.item_code: - msg = f"Please select an valid BOM for Item {item.item_name}." - frappe.throw(_(msg)) + frappe.throw(_(f"Row {item.idx}: Please select an valid BOM for Item {item.item_name}.")) else: - msg = f"Please select a BOM for Item {item.item_name}." - frappe.throw(_(msg)) + frappe.throw(_(f"Row {item.idx}: Please select a BOM for Item {item.item_name}.")) def __get_data_before_save(self): item_dict = {}