mirror of
https://github.com/frappe/erpnext.git
synced 2026-04-15 04:45:09 +00:00
fix: keep per_billed 100 for billed delivery note after return
(cherry picked from commit 8290a83591)
This commit is contained in:
@@ -84,8 +84,8 @@ status_map = {
|
|||||||
"Delivery Note": [
|
"Delivery Note": [
|
||||||
["Draft", None],
|
["Draft", None],
|
||||||
["To Bill", "eval:self.per_billed < 100 and self.docstatus == 1"],
|
["To Bill", "eval:self.per_billed < 100 and self.docstatus == 1"],
|
||||||
["Return Issued", "eval:self.per_returned == 100 and self.docstatus == 1"],
|
|
||||||
["Completed", "eval:self.per_billed == 100 and self.docstatus == 1"],
|
["Completed", "eval:self.per_billed == 100 and self.docstatus == 1"],
|
||||||
|
["Return Issued", "eval:self.per_returned == 100 and self.docstatus == 1"],
|
||||||
["Cancelled", "eval:self.docstatus==2"],
|
["Cancelled", "eval:self.docstatus==2"],
|
||||||
["Closed", "eval:self.status=='Closed' and self.docstatus != 2"],
|
["Closed", "eval:self.status=='Closed' and self.docstatus != 2"],
|
||||||
],
|
],
|
||||||
|
|||||||
@@ -988,7 +988,13 @@ class StockController(AccountsController):
|
|||||||
def update_billing_percentage(self, update_modified=True):
|
def update_billing_percentage(self, update_modified=True):
|
||||||
target_ref_field = "amount"
|
target_ref_field = "amount"
|
||||||
if self.doctype == "Delivery Note":
|
if self.doctype == "Delivery Note":
|
||||||
target_ref_field = "amount - (returned_qty * rate)"
|
total_amount = total_returned = 0
|
||||||
|
for item in self.items:
|
||||||
|
total_amount += flt(item.amount)
|
||||||
|
total_returned += flt(item.returned_qty * item.rate)
|
||||||
|
|
||||||
|
if total_returned < total_amount:
|
||||||
|
target_ref_field = "(amount - (returned_qty * rate))"
|
||||||
|
|
||||||
self._update_percent_field(
|
self._update_percent_field(
|
||||||
{
|
{
|
||||||
|
|||||||
Reference in New Issue
Block a user