From 67c0d08569d159b64444ab39f5962ad5e2856918 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Sun, 14 Dec 2025 14:31:02 +0530 Subject: [PATCH] fix(transaction-deletion): Add virtual doctypes to the list of ignored doctypes (backport #51063) (#51086) * fix: Add virtual doctypes to the list of ignored doctypes in transaction deletion (cherry picked from commit c7a7cb2b9016c38791a7dafb179833448488f4c9) * refactor: switch to `or_filters` so the query hits the DB only once (cherry picked from commit 45a7195abea682419d8e2393679f4981d2fdad9e) * refactor: remove redundant assignment of doctypes_to_be_ignored_list (cherry picked from commit 0f7d89f4d113e7fc276c338f6a41d362e43164d4) --------- Co-authored-by: KerollesFathy --- .../transaction_deletion_record.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py index 5919c21fcbf..44a63579a8e 100644 --- a/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py +++ b/erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py @@ -309,8 +309,9 @@ class TransactionDeletionRecord(Document): self.db_set("error_log", None) def get_doctypes_to_be_ignored_list(self): - singles = frappe.get_all("DocType", filters={"issingle": 1}, pluck="name") - doctypes_to_be_ignored_list = singles + doctypes_to_be_ignored_list = frappe.get_all( + "DocType", or_filters=[["issingle", "=", 1], ["is_virtual", "=", 1]], pluck="name" + ) for doctype in self.doctypes_to_be_ignored: doctypes_to_be_ignored_list.append(doctype.doctype_name)