From 660fc4191ce619dbbffa289afa8c7ba78f73996d Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Thu, 25 Jun 2026 17:30:47 +0530 Subject: [PATCH] chore: rewrite user-facing JS messages in Support module Conservative cleanup of frappe.throw/msgprint messages per the message style guide; meaning, severity, and .format() arguments are unchanged: - index bare {} placeholders as {0}/{1}/... so translators can reorder - move f-strings / .format() / concatenation out of _() (they break gettext extraction and never translate) - wrap translatable dynamic values (DocType/Select labels) in _() - fix grammar and colloquialisms - drop no-op _() wrapping runtime-built strings Part of #53976. --- erpnext/support/doctype/issue/issue.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/support/doctype/issue/issue.js b/erpnext/support/doctype/issue/issue.js index eb53469acd5..8c8cccc4fe0 100644 --- a/erpnext/support/doctype/issue/issue.js +++ b/erpnext/support/doctype/issue/issue.js @@ -123,7 +123,9 @@ frappe.ui.form.on("Issue", { }, (r) => { frappe.msgprint( - `New issue created: ${r.message}` + __("New issue created: {0}", [ + `${r.message}`, + ]) ); frm.reload_doc(); dialog.hide();