nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 03:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: further optimizations

Browse Source
This commit is contained in:
Mihir Kandoi
2025-05-08 15:24:38 +05:30
parent 74eb611563
commit 653e0a2e3a
2 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/stock/doctype/serial_no/serial_no.py
View File

@@ -150,8 +150,6 @@ def get_serial_nos(serial_no):
def get_serial_nos_from_sle_list(bundles): def get_serial_nos_from_sle_list(bundles):
if not bundles:
return {}
table = frappe.qb.DocType("Serial and Batch Entry") table = frappe.qb.DocType("Serial and Batch Entry")
query = frappe.qb.from_(table).select(table.parent, table.serial_no).where(table.parent.isin(bundles)) query = frappe.qb.from_(table).select(table.parent, table.serial_no).where(table.parent.isin(bundles))
data = query.run(as_dict=True) data = query.run(as_dict=True)

19
erpnext/stock/report/available_serial_no/available_serial_no.py
View File

@@ -21,7 +21,7 @@ def execute(filters=None):
sl_entries = get_stock_ledger_entries(filters, items) sl_entries = get_stock_ledger_entries(filters, items)
item_details = get_item_details(items, sl_entries, False) item_details = get_item_details(items, sl_entries, False)
opening_row, actual_qty, stock_value = get_opening_balance_data(filters, columns, sl_entries) opening_row = get_opening_balance_data(filters, columns, sl_entries)
precision = cint(frappe.db.get_single_value("System Settings", "float_precision")) precision = cint(frappe.db.get_single_value("System Settings", "float_precision"))
data = process_stock_ledger_entries(sl_entries, item_details, opening_row, precision) data = process_stock_ledger_entries(sl_entries, item_details, opening_row, precision)
@@ -31,9 +31,7 @@ def execute(filters=None):
def get_opening_balance_data(filters, columns, sl_entries): def get_opening_balance_data(filters, columns, sl_entries):
opening_row = get_opening_balance(filters, columns, sl_entries) opening_row = get_opening_balance(filters, columns, sl_entries)
actual_qty = opening_row.get("qty_after_transaction") if opening_row else 0 return opening_row
stock_value = opening_row.get("stock_value") if opening_row else 0
return opening_row, actual_qty, stock_value
def process_stock_ledger_entries(sl_entries, item_details, opening_row, precision): def process_stock_ledger_entries(sl_entries, item_details, opening_row, precision):
@@ -42,9 +40,9 @@ def process_stock_ledger_entries(sl_entries, item_details, opening_row, precisio
if opening_row: if opening_row:
data.append(opening_row) data.append(opening_row)
available_serial_nos = get_serial_nos_from_sle_list( available_serial_nos = {}
[sle.serial_and_batch_bundle for sle in sl_entries if sle.serial_and_batch_bundle] if sabb_list := [sle.serial_and_batch_bundle for sle in sl_entries if sle.serial_and_batch_bundle]:
) available_serial_nos = get_serial_nos_from_sle_list(sabb_list)
if not available_serial_nos: if not available_serial_nos:
return [], [] return [], []
@@ -221,13 +219,8 @@ def get_columns(filters):
def get_items(filters): def get_items(filters):
item = frappe.qb.DocType("Item") item = frappe.qb.DocType("Item")
query = frappe.qb.from_(item).select(item.name).where(item.has_serial_no == 1) query = frappe.qb.from_(item).select(item.name).where(item.has_serial_no == 1)
conditions = []
if item_code := filters.get("item_code"): if item_code := filters.get("item_code"):
conditions.append(item.name == item_code) query = query.where(item.name == item_code)
if conditions:
for condition in conditions:
query = query.where(condition)
return query.run(pluck=True) return query.run(pluck=True)