From 63cd4349a6efeb42eab2afcc4a897d9a202bd8b6 Mon Sep 17 00:00:00 2001 From: Rucha Mahabal Date: Tue, 9 Aug 2022 18:28:19 +0530 Subject: [PATCH] fix: consider precision while validating advance amount against sanctioned amount --- erpnext/hr/doctype/expense_claim/expense_claim.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/expense_claim/expense_claim.py b/erpnext/hr/doctype/expense_claim/expense_claim.py index 0645bd1f937..43bbede6804 100644 --- a/erpnext/hr/doctype/expense_claim/expense_claim.py +++ b/erpnext/hr/doctype/expense_claim/expense_claim.py @@ -305,8 +305,9 @@ class ExpenseClaim(AccountsController): if self.total_advance_amount: precision = self.precision("total_advance_amount") - amount_with_taxes = flt(self.total_sanctioned_amount, precision) + flt( - self.total_taxes_and_charges, precision + amount_with_taxes = flt( + (flt(self.total_sanctioned_amount, precision) + flt(self.total_taxes_and_charges, precision)), + precision, ) if flt(self.total_advance_amount, precision) > amount_with_taxes: