nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 16:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(task): use get_link_to_form for validation error messages

Browse Source 
(cherry picked from commit 4cf02b4d78)
This commit is contained in:
Pugazhendhi Velu
2025-11-06 11:22:58 +00:00
committed by Mergify
parent dc5b8367c5
commit 635fe427fe
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
erpnext/projects/doctype/task/task.py
View File

@@ -162,15 +162,21 @@ class Task(NestedSet):
def validate_parent_template_task(self): def validate_parent_template_task(self):
if self.parent_task: if self.parent_task:
if not frappe.db.get_value("Task", self.parent_task, "is_template"): if not frappe.db.get_value("Task", self.parent_task, "is_template"):
parent_task_format = f"""<a href="/app/task/{self.parent_task}">{self.parent_task}</a>""" frappe.throw(
frappe.throw(_("Parent Task {0} is not a Template Task").format(parent_task_format)) _("Parent Task {0} is not a Template Task").format(
get_link_to_form("Task", self.parent_task)
)
)
def validate_depends_on_tasks(self): def validate_depends_on_tasks(self):
if self.depends_on: if self.depends_on:
for task in self.depends_on: for task in self.depends_on:
if not frappe.db.get_value("Task", task.task, "is_template"): if not frappe.db.get_value("Task", task.task, "is_template"):
dependent_task_format = f"""<a href="/app/task/{task.task}">{task.task}</a>""" frappe.throw(
frappe.throw(_("Dependent Task {0} is not a Template Task").format(dependent_task_format)) _("Dependent Task {0} is not a Template Task").format(
get_link_to_form("Task", task.task)
)
)
def validate_completed_on(self): def validate_completed_on(self):
if self.completed_on and getdate(self.completed_on) > getdate(): if self.completed_on and getdate(self.completed_on) > getdate():
@@ -179,9 +185,11 @@ class Task(NestedSet):
def validate_parent_is_group(self): def validate_parent_is_group(self):
if self.parent_task: if self.parent_task:
if not frappe.db.get_value("Task", self.parent_task, "is_group"): if not frappe.db.get_value("Task", self.parent_task, "is_group"):
parent_task_format = f"""<a href="/app/task/{self.parent_task}">{self.parent_task}</a>"""
frappe.throw( frappe.throw(
_("Parent Task {0} must be a Group Task").format(parent_task_format), ParentIsGroupError _("Parent Task {0} must be a Group Task").format(
get_link_to_form("Task", self.parent_task)
),
ParentIsGroupError,
) )
def update_depends_on(self): def update_depends_on(self):