Merge pull request #49710 from rohitwaghchaure/fixed-posting-datetime-for-sabb

refactor: posting datetime for SABB

erpnext/controllers/sales_and_purchase_return.py

@@ -13,7 +13,7 @@ from frappe.utils import cint, flt, format_datetime, get_datetime
 import erpnext
 from erpnext.stock.serial_batch_bundle import get_batches_from_bundle
 from erpnext.stock.serial_batch_bundle import get_serial_nos as get_serial_nos_from_bundle
-from erpnext.stock.utils import get_incoming_rate, get_valuation_method
+from erpnext.stock.utils import get_combine_datetime, get_incoming_rate, get_valuation_method
 
 
 class StockOverReturnError(frappe.ValidationError):
@@ -1082,8 +1082,7 @@ def make_serial_batch_bundle_for_return(data, child_doc, parent_doc, warehouse_f
 			"batches": data.get("batches"),
 			"serial_nos_valuation": data.get("serial_nos_valuation"),
 			"batches_valuation": data.get("batches_valuation"),
-			"posting_date": parent_doc.posting_date,
+			"posting_datetime": get_combine_datetime(parent_doc.posting_date, parent_doc.posting_time),
-			"posting_time": parent_doc.posting_time,
 			"voucher_type": parent_doc.doctype,
 			"voucher_no": parent_doc.name,
 			"voucher_detail_no": child_doc.name,

erpnext/controllers/selling_controller.py

@@ -12,7 +12,7 @@ from erpnext.controllers.sales_and_purchase_return import get_rate_for_return
 from erpnext.controllers.stock_controller import StockController
 from erpnext.stock.doctype.item.item import set_item_default
 from erpnext.stock.get_item_details import get_bin_details, get_conversion_factor
-from erpnext.stock.utils import get_incoming_rate, get_valuation_method
+from erpnext.stock.utils import get_combine_datetime, get_incoming_rate, get_valuation_method
 
 
 class SellingController(StockController):
@@ -1017,8 +1017,7 @@ def get_serial_and_batch_bundle(child, parent, delivery_note_child=None):
 			"voucher_type": parent.doctype,
 			"voucher_no": parent.name if parent.docstatus < 2 else None,
 			"voucher_detail_no": delivery_note_child.name if delivery_note_child else child.name,
-			"posting_date": parent.posting_date,
+			"posting_datetime": get_combine_datetime(parent.posting_date, parent.posting_time),
-			"posting_time": parent.posting_time,
 			"qty": child.qty,
 			"type_of_transaction": "Outward" if child.qty > 0 and parent.docstatus < 2 else "Inward",
 			"company": parent.company,

erpnext/controllers/stock_controller.py

@@ -27,6 +27,7 @@ from erpnext.stock.doctype.inventory_dimension.inventory_dimension import (
 	get_evaluated_inventory_dimension,
 )
 from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+	combine_datetime,
 	get_type_of_transaction,
 )
 from erpnext.stock.stock_ledger import get_items_to_be_repost
@@ -266,8 +267,7 @@ class StockController(AccountsController):
 			):
 				bundle_details = {
 					"item_code": row.get("rm_item_code") or row.item_code,
-					"posting_date": self.posting_date,
+					"posting_datetime": combine_datetime(self.posting_date, self.posting_time),
-					"posting_time": self.posting_time,
 					"voucher_type": self.doctype,
 					"voucher_no": self.name,
 					"voucher_detail_no": row.name,

erpnext/controllers/subcontracting_controller.py

@@ -12,6 +12,7 @@ from frappe.utils import cint, flt, get_link_to_form
 
 from erpnext.controllers.stock_controller import StockController
 from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+	combine_datetime,
 	get_voucher_wise_serial_batch_from_bundle,
 )
 from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos
@@ -537,8 +538,7 @@ class SubcontractingController(StockController):
 					"qty": qty,
 					"serial_nos": serial_nos,
 					"batches": batches,
-					"posting_date": self.posting_date,
+					"posting_datetime": combine_datetime(self.posting_date, self.posting_time),
-					"posting_time": self.posting_time,
 					"voucher_type": "Subcontracting Receipt",
 					"do_not_submit": True,
 					"type_of_transaction": "Outward" if qty > 0 else "Inward",

erpnext/patches.txt

@@ -437,3 +437,4 @@ erpnext.patches.v16_0.set_invoice_type_in_pos_settings
 erpnext.patches.v15_0.update_fieldname_in_accounting_dimension_filter
 erpnext.patches.v16_0.make_workstation_operating_components #1
 erpnext.patches.v16_0.set_reporting_currency
+erpnext.patches.v16_0.set_posting_datetime_for_sabb_and_drop_indexes

erpnext/patches/v16_0/set_posting_datetime_for_sabb_and_drop_indexes.py

@@ -0,0 +1,31 @@
+import click
+import frappe
+
+
+def execute():
+	frappe.db.sql(
+		"""
+		UPDATE `tabSerial and Batch Bundle`
+		JOIN `tabStock Ledger Entry`
+		ON `tabSerial and Batch Bundle`.`name` = `tabStock Ledger Entry`.`serial_and_batch_bundle`
+		SET `tabSerial and Batch Bundle`.`posting_datetime` = `tabStock Ledger Entry`.`posting_datetime`
+		WHERE `tabStock Ledger Entry`.`is_cancelled` = 0
+	"""
+	)
+
+	drop_indexes()
+
+
+def drop_indexes():
+	table = "tabSerial and Batch Bundle"
+	index_list = ["voucher_no_index", "item_code_index", "warehouse_index", "company_index"]
+
+	for index in index_list:
+		if not frappe.db.has_index(table, index):
+			continue
+
+		try:
+			frappe.db.sql_ddl(f"ALTER TABLE `{table}` DROP INDEX `{index}`")
+			click.echo(f"✓ dropped {index} index from {table}")
+		except Exception:
+			frappe.log_error("Failed to drop index")

erpnext/stock/deprecated_serial_batch.py

@@ -53,6 +53,11 @@ class DeprecatedSerialNoValuation:
 
 		# get rate from serial nos within same company
 		incoming_values = 0.0
+		posting_datetime = self.sle.posting_datetime
+
+		if not posting_datetime and self.sle.posting_date:
+			posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+
 		for serial_no in serial_nos:
 			sn_details = frappe.db.get_value("Serial No", serial_no, ["purchase_rate", "company"], as_dict=1)
 			if sn_details and sn_details.purchase_rate and sn_details.company == self.sle.company:
@@ -77,7 +82,7 @@ class DeprecatedSerialNoValuation:
 					& (table.actual_qty > 0)
 					& (table.is_cancelled == 0)
 					& table.posting_datetime
-					<= get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+					<= posting_datetime
 				)
 				.orderby(table.posting_datetime, order=Order.desc)
 				.limit(1)
@@ -132,11 +137,8 @@ class DeprecatedBatchNoValuation:
 		sle = frappe.qb.DocType("Stock Ledger Entry")
 
 		timestamp_condition = None
-		if self.sle.posting_date:
+		if self.sle.posting_datetime:
-			if self.sle.posting_time is None:
+			posting_datetime = self.sle.posting_datetime
-				self.sle.posting_time = nowtime()
-
-			posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
 			if not self.sle.creation:
 				posting_datetime = posting_datetime + datetime.timedelta(milliseconds=1)
 
@@ -245,7 +247,11 @@ class DeprecatedBatchNoValuation:
 		sle = frappe.qb.DocType("Stock Ledger Entry")
 		batch = frappe.qb.DocType("Batch")
 
-		posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+		posting_datetime = self.sle.posting_datetime
+
+		if not posting_datetime and self.sle.posting_date:
+			posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+
 		if not self.sle.creation:
 			posting_datetime = posting_datetime + datetime.timedelta(milliseconds=1)
 
@@ -293,7 +299,10 @@ class DeprecatedBatchNoValuation:
 
 		sle = frappe.qb.DocType("Stock Ledger Entry")
 
-		posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+		posting_datetime = self.sle.posting_datetime
+		if not posting_datetime and self.sle.posting_date:
+			posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+
 		if not self.sle.creation:
 			posting_datetime = posting_datetime + datetime.timedelta(milliseconds=1)
 
@@ -343,19 +352,22 @@ class DeprecatedBatchNoValuation:
 		"No known instructions.",
 	)
 	def set_balance_value_from_bundle(self) -> None:
+		from erpnext.stock.utils import get_combine_datetime
+
 		bundle = frappe.qb.DocType("Serial and Batch Bundle")
 		bundle_child = frappe.qb.DocType("Serial and Batch Entry")
 		batch = frappe.qb.DocType("Batch")
 
-		timestamp_condition = CombineDatetime(bundle.posting_date, bundle.posting_time) < CombineDatetime(
+		posting_datetime = self.sle.posting_datetime
-			self.sle.posting_date, self.sle.posting_time
+		if not posting_datetime and self.sle.posting_date:
-		)
+			posting_datetime = get_combine_datetime(self.sle.posting_date, self.sle.posting_time)
+
+		timestamp_condition = bundle.posting_datetime < posting_datetime
 
 		if self.sle.creation:
-			timestamp_condition |= (
+			timestamp_condition |= (bundle.posting_datetime == posting_datetime) & (
-				CombineDatetime(bundle.posting_date, bundle.posting_time)
+				bundle.creation < self.sle.creation
-				== CombineDatetime(self.sle.posting_date, self.sle.posting_time)
+			)
-			) & (bundle.creation < self.sle.creation)
 
 		query = (
 			frappe.qb.from_(bundle)

erpnext/stock/doctype/batch/batch.py

@@ -219,6 +219,7 @@ def get_batch_qty(
 	warehouse=None,
 	item_code=None,
 	creation=None,
+	posting_datetime=None,
 	posting_date=None,
 	posting_time=None,
 	ignore_voucher_nos=None,
@@ -237,6 +238,7 @@ def get_batch_qty(
 	:param for_stock_levels: True consider expired batches"""
 
 	from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+		combine_datetime,
 		get_auto_batch_nos,
 	)
 
@@ -246,8 +248,6 @@ def get_batch_qty(
 			"item_code": item_code,
 			"warehouse": warehouse,
 			"creation": creation,
-			"posting_date": posting_date,
-			"posting_time": posting_time,
 			"batch_no": batch_no,
 			"ignore_voucher_nos": ignore_voucher_nos,
 			"for_stock_levels": for_stock_levels,
@@ -256,6 +256,10 @@ def get_batch_qty(
 		}
 	)
 
+	kwargs["posting_datetime"] = posting_datetime
+	if not kwargs.get("posting_datetime") and posting_date:
+		kwargs["posting_datetime"] = combine_datetime(posting_date, posting_time)
+
 	batches = get_auto_batch_nos(kwargs)
 
 	if not (batch_no and warehouse):
@@ -337,6 +341,7 @@ def make_batch_bundle(
 ):
 	from frappe.utils import nowtime, today
 
+	from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import combine_datetime
 	from erpnext.stock.serial_batch_bundle import SerialBatchCreation
 
 	return (
@@ -344,8 +349,7 @@ def make_batch_bundle(
 			{
 				"item_code": item_code,
 				"warehouse": warehouse,
-				"posting_date": today(),
+				"posting_datetime": combine_datetime(today(), nowtime()),
-				"posting_time": nowtime(),
 				"voucher_type": "Stock Entry",
 				"qty": qty,
 				"type_of_transaction": type_of_transaction,
@@ -456,9 +460,13 @@ def get_pos_reserved_batch_qty(filters):
 
 def get_available_batches(kwargs):
 	from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+		combine_datetime,
 		get_auto_batch_nos,
 	)
 
+	if kwargs.get("posting_date"):
+		kwargs["posting_datetime"] = combine_datetime(kwargs.get("posting_date"), kwargs.get("posting_time"))
+
 	batchwise_qty = OrderedDict()
 
 	batches = get_auto_batch_nos(kwargs)

erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.json

@@ -29,8 +29,7 @@
   "voucher_no",
   "voucher_detail_no",
   "column_break_aouy",
-  "posting_date",
+  "posting_datetime",
-  "posting_time",
   "returned_against",
   "section_break_wzou",
   "is_cancelled",
@@ -50,8 +49,7 @@
    "in_list_view": 1,
    "label": "Company",
    "options": "Company",
-   "reqd": 1,
+   "reqd": 1
-   "search_index": 1
   },
   {
    "fetch_from": "item_code.item_group",
@@ -80,8 +78,7 @@
    "in_standard_filter": 1,
    "label": "Item Code",
    "options": "Item",
-   "reqd": 1,
+   "reqd": 1
-   "search_index": 1
   },
   {
    "fetch_from": "item_code.item_name",
@@ -118,8 +115,7 @@
    "in_standard_filter": 1,
    "label": "Voucher No",
    "no_copy": 1,
-   "options": "voucher_type",
+   "options": "voucher_type"
-   "search_index": 1
   },
   {
    "default": "0",
@@ -189,8 +185,7 @@
    "in_standard_filter": 1,
    "label": "Warehouse",
    "mandatory_depends_on": "eval:doc.type_of_transaction != \"Maintenance\"",
-   "options": "Warehouse",
+   "options": "Warehouse"
-   "search_index": 1
   },
   {
    "fieldname": "type_of_transaction",
@@ -212,18 +207,6 @@
    "fieldname": "section_break_wzou",
    "fieldtype": "Section Break"
   },
-  {
-   "fieldname": "posting_date",
-   "fieldtype": "Date",
-   "label": "Posting Date",
-   "no_copy": 1
-  },
-  {
-   "fieldname": "posting_time",
-   "fieldtype": "Time",
-   "label": "Posting Time",
-   "no_copy": 1
-  },
   {
    "fieldname": "voucher_detail_no",
    "fieldtype": "Data",
@@ -258,13 +241,18 @@
    "fieldname": "is_packed",
    "fieldtype": "Check",
    "label": "Is Packed"
+  },
+  {
+   "fieldname": "posting_datetime",
+   "fieldtype": "Datetime",
+   "label": "Posting Datetime"
   }
  ],
  "grid_page_length": 50,
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2025-09-15 14:37:26.441742",
+ "modified": "2025-09-24 16:24:48.154853",
  "modified_by": "Administrator",
  "module": "Stock",
  "name": "Serial and Batch Bundle",

erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py

@@ -73,8 +73,7 @@ class SerialandBatchBundle(Document):
 		item_group: DF.Link | None
 		item_name: DF.Data | None
 		naming_series: DF.Literal["", "SABB-.########"]
-		posting_date: DF.Date | None
+		posting_datetime: DF.Datetime | None
-		posting_time: DF.Time | None
 		returned_against: DF.Data | None
 		total_amount: DF.Float
 		total_qty: DF.Float
@@ -252,8 +251,7 @@ class SerialandBatchBundle(Document):
 			kwargs.update(
 				{
 					"voucher_no": self.voucher_no,
-					"posting_date": self.posting_date,
+					"posting_datetime": self.posting_datetime,
-					"posting_time": self.posting_time,
 				}
 			)
 
@@ -291,8 +289,7 @@ class SerialandBatchBundle(Document):
 		kwargs = frappe._dict(
 			{
 				"item_code": self.item_code,
-				"posting_date": self.posting_date,
+				"posting_datetime": self.posting_datetime,
-				"posting_time": self.posting_time,
 				"serial_nos": serial_nos,
 				"check_serial_nos": True,
 			}
@@ -560,8 +557,7 @@ class SerialandBatchBundle(Document):
 	def get_sle_for_outward_transaction(self):
 		sle = frappe._dict(
 			{
-				"posting_date": self.posting_date,
+				"posting_datetime": self.posting_datetime,
-				"posting_time": self.posting_time,
 				"item_code": self.item_code,
 				"warehouse": self.warehouse,
 				"serial_and_batch_bundle": self.name,
@@ -662,11 +658,10 @@ class SerialandBatchBundle(Document):
 		if not self.voucher_detail_no or self.voucher_detail_no != row.name:
 			values_to_set["voucher_detail_no"] = row.name
 
-		if parent.get("posting_date") and (not self.posting_date or self.posting_date != parent.posting_date):
+		if parent.get("posting_date") and parent.get("posting_time"):
-			values_to_set["posting_date"] = parent.posting_date or today()
+			posting_datetime = combine_datetime(parent.posting_date, parent.posting_time)
-
+			if not self.posting_datetime or self.posting_datetime != posting_datetime:
-		if parent.get("posting_time") and (not self.posting_time or self.posting_time != parent.posting_time):
+				values_to_set["posting_datetime"] = posting_datetime
-			values_to_set["posting_time"] = parent.posting_time
 
 		if parent.doctype in [
 			"Delivery Note",
@@ -741,9 +736,7 @@ class SerialandBatchBundle(Document):
 		parent = frappe.qb.DocType("Serial and Batch Bundle")
 		child = frappe.qb.DocType("Serial and Batch Entry")
 
-		timestamp_condition = CombineDatetime(parent.posting_date, parent.posting_time) > CombineDatetime(
+		timestamp_condition = parent.posting_datetime > self.posting_datetime
-			self.posting_date, self.posting_time
-		)
 
 		future_entries = (
 			frappe.qb.from_(parent)
@@ -1251,7 +1244,7 @@ class SerialandBatchBundle(Document):
 				frappe.qb.update(sn_table)
 				.set(sn_table.reference_doctype, self.voucher_type)
 				.set(sn_table.reference_name, self.voucher_no)
-				.set(sn_table.posting_date, self.posting_date)
+				.set(sn_table.posting_date, getdate(self.posting_datetime))
 				.where((sn_table.name.isin(serial_nos)) & (sn_table.reference_name.isnull()))
 			).run()
 
@@ -1700,6 +1693,8 @@ def create_serial_batch_no_ledgers(
 	if parent_doc.get("doctype") == "Stock Entry":
 		warehouse = warehouse or child_row.s_warehouse or child_row.t_warehouse
 
+	posting_datetime = combine_datetime(parent_doc.get("posting_date"), parent_doc.get("posting_time"))
+
 	doc = frappe.get_doc(
 		{
 			"doctype": "Serial and Batch Bundle",
@@ -1708,8 +1703,7 @@ def create_serial_batch_no_ledgers(
 			"warehouse": warehouse,
 			"is_rejected": child_row.is_rejected,
 			"type_of_transaction": type_of_transaction,
-			"posting_date": parent_doc.get("posting_date"),
+			"posting_datetime": posting_datetime,
-			"posting_time": parent_doc.get("posting_time"),
 			"company": parent_doc.get("company"),
 		}
 	)
@@ -1745,6 +1739,12 @@ def create_serial_batch_no_ledgers(
 	return doc
 
 
+def combine_datetime(date, time=None):
+	from erpnext.stock.utils import get_combine_datetime
+
+	return get_combine_datetime(date, time)
+
+
 def get_batch(item_code):
 	from erpnext.stock.doctype.batch.batch import make_batch
 
@@ -1788,8 +1788,8 @@ def get_type_of_transaction(parent_doc, child_row):
 def update_serial_batch_no_ledgers(bundle, entries, child_row, parent_doc, warehouse=None) -> object:
 	doc = frappe.get_doc("Serial and Batch Bundle", bundle)
 	doc.voucher_detail_no = child_row.name
-	doc.posting_date = parent_doc.posting_date
+	doc.posting_datetime = combine_datetime(parent_doc.get("posting_date"), parent_doc.get("posting_time"))
-	doc.posting_time = parent_doc.posting_time
+
 	doc.warehouse = warehouse or doc.warehouse
 	doc.set("entries", [])
 
@@ -1896,6 +1896,9 @@ def get_available_serial_nos(kwargs):
 	elif kwargs.based_on == "Expiry":
 		order_by = "amc_expiry_date asc"
 
+	if not kwargs.get("posting_datetime") and kwargs.get("posting_date"):
+		kwargs["posting_datetime"] = combine_datetime(kwargs.get("posting_date"), kwargs.get("posting_time"))
+
 	filters = {"item_code": kwargs.item_code}
 
 	# ignore_warehouse is used for backdated stock transactions
@@ -1941,10 +1944,7 @@ def get_available_serial_nos(kwargs):
 		ignore_serial_nos.extend(kwargs.get("ignore_serial_nos"))
 
 	ignore_serial_nos = list(set(ignore_serial_nos))
-	if kwargs.get("posting_date"):
+	if kwargs.get("posting_datetime"):
-		if kwargs.get("posting_time") is None:
-			kwargs.posting_time = nowtime()
-
 		time_based_serial_nos = get_serial_nos_based_on_posting_date(kwargs, ignore_serial_nos)
 
 		if not time_based_serial_nos:
@@ -2343,11 +2343,13 @@ def get_auto_batch_nos(kwargs):
 			kwargs.batch_no = batches
 			kwargs.warehouse = warehouses
 
+	if not kwargs.get("posting_datetime") and kwargs.get("posting_date"):
+		kwargs["posting_datetime"] = combine_datetime(kwargs.get("posting_date"), kwargs.get("posting_time"))
+
 	available_batches = get_available_batches(kwargs)
 	stock_ledgers_batches = get_stock_ledgers_batches(kwargs)
 	pos_invoice_batches = get_reserved_batches_for_pos(kwargs)
 	sre_reserved_batches = get_reserved_batches_for_sre(kwargs)
-
 	if kwargs.against_sales_order and only_consider_batches:
 		kwargs.batch_no = kwargs.warehouse = None
 
@@ -2367,7 +2369,7 @@ def get_auto_batch_nos(kwargs):
 	if kwargs.based_on == "Expiry":
 		available_batches = sorted(available_batches, key=lambda x: (x.expiry_date or getdate("9999-12-31")))
 
-	if not kwargs.get("do_not_check_future_batches") and available_batches and kwargs.get("posting_date"):
+	if not kwargs.get("do_not_check_future_batches") and available_batches and kwargs.get("posting_datetime"):
 		filter_zero_near_batches(available_batches, kwargs)
 
 	if not kwargs.consider_negative_batches:
@@ -2404,8 +2406,7 @@ def get_batches_to_be_considered(sales_order_name):
 def filter_zero_near_batches(available_batches, kwargs):
 	kwargs.batch_no = [d.batch_no for d in available_batches]
 
-	del kwargs["posting_date"]
+	del kwargs["posting_datetime"]
-	del kwargs["posting_time"]
 
 	kwargs.do_not_check_future_batches = 1
 	available_batches_in_future = get_auto_batch_nos(kwargs)
@@ -2471,8 +2472,6 @@ def update_available_batches(available_batches, *reserved_batches) -> None:
 
 
 def get_available_batches(kwargs):
-	from erpnext.stock.utils import get_combine_datetime
-
 	stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry")
 	batch_ledger = frappe.qb.DocType("Serial and Batch Entry")
 	batch_table = frappe.qb.DocType("Batch")
@@ -2497,23 +2496,15 @@ def get_available_batches(kwargs):
 	if not kwargs.get("for_stock_levels"):
 		query = query.where((batch_table.expiry_date >= today()) | (batch_table.expiry_date.isnull()))
 
-	if kwargs.get("posting_date"):
+	if kwargs.get("posting_datetime"):
-		if kwargs.get("posting_time") is None:
+		timestamp_condition = stock_ledger_entry.posting_datetime <= kwargs.posting_datetime
-			kwargs.posting_time = nowtime()
-
-		timestamp_condition = stock_ledger_entry.posting_datetime <= get_combine_datetime(
-			kwargs.posting_date, kwargs.posting_time
-		)
 
 		if kwargs.get("creation"):
-			timestamp_condition = stock_ledger_entry.posting_datetime < get_combine_datetime(
+			timestamp_condition = stock_ledger_entry.posting_datetime < kwargs.posting_datetime
-				kwargs.posting_date, kwargs.posting_time
-			)
 
-			timestamp_condition |= (
+			timestamp_condition |= (stock_ledger_entry.posting_datetime == kwargs.posting_datetime) & (
-				stock_ledger_entry.posting_datetime
+				stock_ledger_entry.creation < kwargs.creation
-				== get_combine_datetime(kwargs.posting_date, kwargs.posting_time)
+			)
-			) & (stock_ledger_entry.creation < kwargs.creation)
 
 		query = query.where(timestamp_condition)
 
@@ -2693,15 +2684,14 @@ def get_ledgers_from_serial_batch_bundle(**kwargs) -> list[frappe._dict]:
 			serial_batch_table.incoming_rate,
 			bundle_table.voucher_detail_no,
 			bundle_table.voucher_no,
-			bundle_table.posting_date,
+			bundle_table.posting_datetime,
-			bundle_table.posting_time,
 		)
 		.where(
 			(bundle_table.docstatus == 1)
 			& (bundle_table.is_cancelled == 0)
 			& (bundle_table.type_of_transaction.isin(["Inward", "Outward"]))
 		)
-		.orderby(bundle_table.posting_date, bundle_table.posting_time)
+		.orderby(bundle_table.posting_datetime)
 	)
 
 	for key, val in kwargs.items():
@@ -2719,7 +2709,7 @@ def get_ledgers_from_serial_batch_bundle(**kwargs) -> list[frappe._dict]:
 				query = query.where(bundle_table[key].isin(val))
 			else:
 				query = query.where(bundle_table[key] == val)
-		elif key in ["posting_date", "posting_time"]:
+		elif key in ["posting_datetime"]:
 			query = query.where(bundle_table[key] >= val)
 		else:
 			if isinstance(val, list):
@@ -2731,8 +2721,6 @@ def get_ledgers_from_serial_batch_bundle(**kwargs) -> list[frappe._dict]:
 
 
 def get_stock_ledgers_for_serial_nos(kwargs):
-	from erpnext.stock.utils import get_combine_datetime
-
 	stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry")
 
 	query = (
@@ -2748,23 +2736,15 @@ def get_stock_ledgers_for_serial_nos(kwargs):
 		.orderby(stock_ledger_entry.creation)
 	)
 
-	if kwargs.get("posting_date"):
+	if kwargs.get("posting_datetime"):
-		if kwargs.get("posting_time") is None:
+		timestamp_condition = stock_ledger_entry.posting_datetime <= kwargs.posting_datetime
-			kwargs.posting_time = nowtime()
-
-		timestamp_condition = stock_ledger_entry.posting_datetime <= get_combine_datetime(
-			kwargs.posting_date, kwargs.posting_time
-		)
 
 		if kwargs.get("creation"):
-			timestamp_condition = stock_ledger_entry.posting_datetime < get_combine_datetime(
+			timestamp_condition = stock_ledger_entry.posting_datetime < kwargs.posting_datetime
-				kwargs.posting_date, kwargs.posting_time
-			)
 
-			timestamp_condition |= (
+			timestamp_condition |= (stock_ledger_entry.posting_datetime == kwargs.posting_datetime) & (
-				stock_ledger_entry.posting_datetime
+				stock_ledger_entry.creation < kwargs.creation
-				== get_combine_datetime(kwargs.posting_date, kwargs.posting_time)
+			)
-			) & (stock_ledger_entry.creation < kwargs.creation)
 
 		query = query.where(timestamp_condition)
 
@@ -2784,8 +2764,6 @@ def get_stock_ledgers_for_serial_nos(kwargs):
 
 
 def get_stock_ledgers_batches(kwargs):
-	from erpnext.stock.utils import get_combine_datetime
-
 	stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry")
 	batch_table = frappe.qb.DocType("Batch")
 
@@ -2816,23 +2794,15 @@ def get_stock_ledgers_batches(kwargs):
 	if not kwargs.get("for_stock_levels"):
 		query = query.where((batch_table.expiry_date >= today()) | (batch_table.expiry_date.isnull()))
 
-	if kwargs.get("posting_date"):
+	if kwargs.get("posting_datetime"):
-		if kwargs.get("posting_time") is None:
+		timestamp_condition = stock_ledger_entry.posting_datetime <= kwargs.posting_datetime
-			kwargs.posting_time = nowtime()
-
-		timestamp_condition = stock_ledger_entry.posting_datetime <= get_combine_datetime(
-			kwargs.posting_date, kwargs.posting_time
-		)
 
 		if kwargs.get("creation"):
-			timestamp_condition = stock_ledger_entry.posting_datetime < get_combine_datetime(
+			timestamp_condition = stock_ledger_entry.posting_datetime < kwargs.posting_datetime
-				kwargs.posting_date, kwargs.posting_time
-			)
 
-			timestamp_condition |= (
+			timestamp_condition |= (stock_ledger_entry.posting_datetime == kwargs.posting_datetime) & (
-				stock_ledger_entry.posting_datetime
+				stock_ledger_entry.creation < kwargs.creation
-				== get_combine_datetime(kwargs.posting_date, kwargs.posting_time)
+			)
-			) & (stock_ledger_entry.creation < kwargs.creation)
 
 		query = query.where(timestamp_condition)
 
@@ -2920,3 +2890,7 @@ def get_stock_reco_details(voucher_detail_no):
 		],
 		as_dict=True,
 	)
+
+
+def on_doctype_update():
+	frappe.db.add_index("Serial and Batch Bundle", ["item_code", "warehouse", "posting_datetime", "creation"])

erpnext/stock/doctype/serial_and_batch_bundle/test_serial_and_batch_bundle.py

@@ -10,6 +10,7 @@ from frappe.utils import flt, nowtime, today
 from erpnext.stock.doctype.item.test_item import make_item
 from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
 	add_serial_batch_ledgers,
+	combine_datetime,
 	make_batch_nos,
 	make_serial_nos,
 )
@@ -932,14 +933,17 @@ def make_serial_batch_bundle(kwargs):
 	if kwargs.get("type_of_transaction"):
 		type_of_transaction = kwargs.get("type_of_transaction")
 
+	posting_datetime = None
+	if kwargs.get("posting_date"):
+		posting_datetime = combine_datetime(kwargs.posting_date, kwargs.posting_time or nowtime())
+
 	sb = SerialBatchCreation(
 		{
 			"item_code": kwargs.item_code,
 			"warehouse": kwargs.warehouse,
 			"voucher_type": kwargs.voucher_type,
 			"voucher_no": kwargs.voucher_no,
-			"posting_date": kwargs.posting_date,
+			"posting_datetime": posting_datetime,
-			"posting_time": kwargs.posting_time,
 			"qty": kwargs.qty,
 			"avg_rate": kwargs.rate,
 			"batches": kwargs.batches,

erpnext/stock/doctype/stock_entry/stock_entry.py

@@ -54,7 +54,7 @@ from erpnext.stock.serial_batch_bundle import (
 	get_serial_or_batch_items,
 )
 from erpnext.stock.stock_ledger import NegativeStockError, get_previous_sle, get_valuation_rate
-from erpnext.stock.utils import get_bin, get_incoming_rate
+from erpnext.stock.utils import get_bin, get_combine_datetime, get_incoming_rate
 
 
 class FinishedGoodError(frappe.ValidationError):
@@ -1122,8 +1122,7 @@ class StockEntry(StockController):
 					{
 						"item_code": row.item_code,
 						"warehouse": row.s_warehouse,
-						"posting_date": self.posting_date,
+						"posting_datetime": get_combine_datetime(self.posting_date, self.posting_time),
-						"posting_time": self.posting_time,
 						"voucher_type": self.doctype,
 						"voucher_detail_no": row.name,
 						"qty": row.transfer_qty * -1,

erpnext/stock/doctype/stock_entry/stock_entry_utils.py

@@ -8,6 +8,7 @@ import frappe
 from frappe.utils import cint, flt
 
 import erpnext
+from erpnext.stock.utils import get_combine_datetime
 
 if TYPE_CHECKING:
 	from erpnext.stock.doctype.stock_entry.stock_entry import StockEntry
@@ -140,6 +141,10 @@ def make_stock_entry(**args):
 		elif args.batches:
 			batches = args.batches
 
+		posting_datetime = None
+		if args.posting_date and args.posting_time:
+			posting_datetime = get_combine_datetime(args.posting_date, args.posting_time)
+
 		bundle_id = (
 			SerialBatchCreation(
 				{
@@ -151,8 +156,7 @@ def make_stock_entry(**args):
 					"serial_nos": args.serial_no,
 					"type_of_transaction": "Outward" if args.source else "Inward",
 					"company": s.company,
-					"posting_date": s.posting_date,
+					"posting_datetime": posting_datetime,
-					"posting_time": s.posting_time,
 					"rate": args.rate or args.basic_rate,
 					"do_not_submit": True,
 				}

erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py

@@ -13,6 +13,7 @@ from erpnext.controllers.stock_controller import StockController, create_repost_
 from erpnext.stock.doctype.batch.batch import get_available_batches, get_batch_qty
 from erpnext.stock.doctype.inventory_dimension.inventory_dimension import get_inventory_dimensions
 from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+	combine_datetime,
 	get_available_serial_nos,
 )
 from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos
@@ -135,8 +136,7 @@ class StockReconciliation(StockController):
 					{
 						"item_code": row.item_code,
 						"warehouse": row.warehouse,
-						"posting_date": self.posting_date,
+						"posting_datetime": combine_datetime(self.posting_date, self.posting_time),
-						"posting_time": self.posting_time,
 						"voucher_type": self.doctype,
 						"voucher_no": self.name,
 						"voucher_detail_no": row.name,
@@ -242,8 +242,7 @@ class StockReconciliation(StockController):
 						"doctype": "Serial and Batch Bundle",
 						"item_code": item.item_code,
 						"warehouse": item.warehouse,
-						"posting_date": self.posting_date,
+						"posting_datetime": combine_datetime(self.posting_date, self.posting_time),
-						"posting_time": self.posting_time,
 						"voucher_type": self.doctype,
 						"type_of_transaction": "Outward",
 					}
@@ -261,8 +260,7 @@ class StockReconciliation(StockController):
 						{
 							"item_code": item.item_code,
 							"warehouse": item.warehouse,
-							"posting_date": self.posting_date,
+							"posting_datetime": combine_datetime(self.posting_date, self.posting_time),
-							"posting_time": self.posting_time,
 							"ignore_warehouse": 1,
 						}
 					)
@@ -1154,8 +1152,7 @@ class StockReconciliation(StockController):
 				{
 					"item_code": doc.item_code,
 					"warehouse": doc.warehouse,
-					"posting_date": self.posting_date,
+					"posting_datetime": doc.posting_datetime,
-					"posting_time": self.posting_time,
 					"creation": sle_creation,
 					"voucher_no": self.name,
 					"ignore_warehouse": 1,
@@ -1195,8 +1192,7 @@ class StockReconciliation(StockController):
 					d.batch_no,
 					doc.warehouse,
 					creation=sle_creation,
-					posting_date=doc.posting_date,
+					posting_datetime=doc.posting_datetime,
-					posting_time=doc.posting_time,
 					ignore_voucher_nos=[doc.voucher_no],
 					for_stock_levels=True,
 					consider_negative_batches=True,

erpnext/stock/report/serial_and_batch_summary/serial_and_batch_summary.py

@@ -19,7 +19,7 @@ def get_data(filters):
 		"Serial and Batch Bundle",
 		fields=[
 			"`tabSerial and Batch Bundle`.`voucher_type`",
-			"`tabSerial and Batch Bundle`.`posting_date`",
+			"`tabSerial and Batch Bundle`.`posting_datetime` as posting_date",
 			"`tabSerial and Batch Bundle`.`name`",
 			"`tabSerial and Batch Bundle`.`company`",
 			"`tabSerial and Batch Bundle`.`voucher_no`",
@@ -33,7 +33,7 @@ def get_data(filters):
 			"`tabSerial and Batch Entry`.`qty`",
 		],
 		filters=filter_conditions,
-		order_by="posting_date",
+		order_by="posting_datetime",
 	)
 
 
@@ -54,7 +54,7 @@ def get_filter_conditions(filters):
 		filter_conditions.append(
 			[
 				"Serial and Batch Bundle",
-				"posting_date",
+				"posting_datetime",
 				"between",
 				[filters.get("from_date"), filters.get("to_date")],
 			]

erpnext/stock/report/stock_ageing/stock_ageing.py

@@ -492,6 +492,7 @@ class FIFOSlots:
 		bundle = frappe.qb.DocType("Serial and Batch Bundle")
 		entry = frappe.qb.DocType("Serial and Batch Entry")
 
+		to_date = get_datetime(self.filters.get("to_date") + " 23:59:59")
 		query = (
 			frappe.qb.from_(bundle)
 			.join(entry)
@@ -501,7 +502,7 @@ class FIFOSlots:
 				(bundle.docstatus == 1)
 				& (entry.serial_no.isnotnull())
 				& (bundle.company == self.filters.get("company"))
-				& (bundle.posting_date <= self.filters.get("to_date"))
+				& (bundle.posting_datetime <= to_date)
 			)
 		)
 

erpnext/stock/serial_batch_bundle.py

@@ -4,7 +4,7 @@ import frappe
 from frappe import _, bold
 from frappe.model.naming import make_autoname
 from frappe.query_builder.functions import CombineDatetime, Sum, Timestamp
-from frappe.utils import add_days, cint, cstr, flt, get_link_to_form, now, nowtime, today
+from frappe.utils import add_days, cint, cstr, flt, get_link_to_form, getdate, now, nowtime, today
 from pypika import Order
 from pypika.terms import ExistsCriterion
 
@@ -100,8 +100,7 @@ class SerialBatchBundle:
 			{
 				"item_code": self.item_code,
 				"warehouse": self.warehouse,
-				"posting_date": self.sle.posting_date,
+				"posting_datetime": self.sle.posting_datetime,
-				"posting_time": self.sle.posting_time,
 				"voucher_type": self.sle.voucher_type,
 				"voucher_no": self.sle.voucher_no,
 				"voucher_detail_no": self.sle.voucher_detail_no,
@@ -463,7 +462,7 @@ class SerialBatchBundle:
 		if status == "Delivered":
 			warranty_period = frappe.get_cached_value("Item", sle.item_code, "warranty_period")
 			if warranty_period:
-				warranty_expiry_date = add_days(sle.posting_date, cint(warranty_period))
+				warranty_expiry_date = add_days(getdate(sle.posting_datetime), cint(warranty_period))
 				query = query.set(sn_table.warranty_expiry_date, warranty_expiry_date)
 				query = query.set(sn_table.warranty_period, warranty_period)
 		else:
@@ -488,7 +487,7 @@ class SerialBatchBundle:
 					sle_doctype.voucher_no,
 					sle_doctype.is_cancelled,
 					sle_doctype.item_code,
-					sle_doctype.posting_date,
+					sle_doctype.posting_datetime,
 					sle_doctype.company,
 				)
 				.where(
@@ -644,7 +643,7 @@ class SerialNoValuation(DeprecatedSerialNoValuation):
 				& (bundle.item_code == self.sle.item_code)
 				& (bundle_child.warehouse == self.sle.warehouse)
 			)
-			.orderby(Timestamp(bundle.posting_date, bundle.posting_time), order=Order.desc)
+			.orderby(bundle.posting_datetime, order=Order.desc)
 			.limit(1)
 		)
 
@@ -652,13 +651,8 @@ class SerialNoValuation(DeprecatedSerialNoValuation):
 		if self.sle.voucher_no:
 			query = query.where(bundle.voucher_no != self.sle.voucher_no)
 
-		if self.sle.posting_date:
+		if self.sle.posting_datetime:
-			if self.sle.posting_time is None:
+			timestamp_condition = bundle.posting_datetime <= self.sle.posting_datetime
-				self.sle.posting_time = nowtime()
-
-			timestamp_condition = CombineDatetime(
-				bundle.posting_date, bundle.posting_time
-			) <= CombineDatetime(self.sle.posting_date, self.sle.posting_time)
 
 			query = query.where(timestamp_condition)
 
@@ -754,19 +748,13 @@ class BatchNoValuation(DeprecatedBatchNoValuation):
 		child = frappe.qb.DocType("Serial and Batch Entry")
 
 		timestamp_condition = ""
-		if self.sle.posting_date:
+		if self.sle.posting_datetime:
-			if self.sle.posting_time is None:
+			timestamp_condition = parent.posting_datetime < self.sle.posting_datetime
-				self.sle.posting_time = nowtime()
-
-			timestamp_condition = CombineDatetime(parent.posting_date, parent.posting_time) < CombineDatetime(
-				self.sle.posting_date, self.sle.posting_time
-			)
 
 			if self.sle.creation:
-				timestamp_condition |= (
+				timestamp_condition |= (parent.posting_datetime == self.sle.posting_datetime) & (
-					CombineDatetime(parent.posting_date, parent.posting_time)
+					parent.creation < self.sle.creation
-					== CombineDatetime(self.sle.posting_date, self.sle.posting_time)
+				)
-				) & (parent.creation < self.sle.creation)
 
 		query = (
 			frappe.qb.from_(parent)
@@ -989,9 +977,9 @@ class SerialBatchCreation:
 		self.__dict__.update(item_details)
 
 	def set_other_details(self):
-		if not self.get("posting_date"):
+		if not self.get("posting_datetime"):
-			self.posting_date = today()
+			self.posting_datetime = now()
-			self.__dict__["posting_date"] = self.posting_date
+			self.__dict__["posting_datetime"] = self.posting_datetime
 
 		if not self.get("actual_qty"):
 			qty = self.get("qty") or self.get("total_qty")
@@ -1016,8 +1004,7 @@ class SerialBatchCreation:
 		new_package.docstatus = 0
 		new_package.warehouse = self.warehouse
 		new_package.voucher_no = ""
-		new_package.posting_date = self.posting_date if hasattr(self, "posting_date") else today()
+		new_package.posting_datetime = self.posting_datetime if hasattr(self, "posting_datetime") else now()
-		new_package.posting_time = self.posting_time if hasattr(self, "posting_time") else nowtime()
 		new_package.type_of_transaction = self.type_of_transaction
 		new_package.returned_against = self.get("returned_against")
 
@@ -1144,9 +1131,8 @@ class SerialBatchCreation:
 		elif self.has_serial_no and not self.get("serial_nos"):
 			self.serial_nos = get_serial_nos_for_outward(kwargs)
 		elif not self.has_serial_no and self.has_batch_no and not self.get("batches"):
-			if self.get("posting_date"):
+			if self.get("posting_datetime"):
-				kwargs["posting_date"] = self.get("posting_date")
+				kwargs["posting_datetime"] = self.get("posting_datetime")
-				kwargs["posting_time"] = self.get("posting_time")
 
 			self.batches = get_available_batches(kwargs)
 

erpnext/stock/stock_ledger.py

@@ -1863,8 +1863,7 @@ def get_valuation_rate(
 					"warehouse": warehouse,
 					"actual_qty": -1,
 					"serial_and_batch_bundle": serial_and_batch_bundle,
-					"posting_date": sabb.posting_date,
+					"posting_datetime": get_combine_datetime(sabb.posting_date, sabb.posting_time),
-					"posting_time": sabb.posting_time,
 				}
 			)
 		)
@@ -2208,8 +2207,7 @@ def validate_reserved_batch_nos(item_code, warehouse, batch_nos):
 				{
 					"item_code": item_code,
 					"warehouse": warehouse,
-					"posting_date": nowdate(),
+					"posting_datetime": get_combine_datetime(nowdate(), nowtime()),
-					"posting_time": nowtime(),
 				}
 			)
 		)

erpnext/stock/utils.py

@@ -10,9 +10,7 @@ from frappe.query_builder.functions import CombineDatetime, IfNull, Sum
 from frappe.utils import cstr, flt, get_link_to_form, get_time, getdate, nowdate, nowtime
 
 import erpnext
-from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import (
+from erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle import get_available_serial_nos
-	get_available_serial_nos,
-)
 from erpnext.stock.doctype.warehouse.warehouse import get_child_warehouses
 from erpnext.stock.serial_batch_bundle import BatchNoValuation, SerialNoValuation
 from erpnext.stock.valuation import FIFOValuation, LIFOValuation
@@ -139,8 +137,7 @@ def get_stock_balance(
 					{
 						"item_code": item_code,
 						"warehouse": warehouse,
-						"posting_date": posting_date,
+						"posting_datetime": get_combine_datetime(posting_date, posting_time),
-						"posting_time": posting_time,
 						"ignore_warehouse": 1,
 					}
 				)
@@ -244,6 +241,9 @@ def get_incoming_rate(args, raise_error_if_no_rate=True):
 	"""Get Incoming Rate based on valuation method"""
 	from erpnext.stock.stock_ledger import get_previous_sle, get_valuation_rate
 
+	if not args.get("posting_datetime") and args.get("posting_date"):
+		args["posting_datetime"] = get_combine_datetime(args.get("posting_date"), args.get("posting_time"))
+
 	if isinstance(args, str):
 		args = json.loads(args)