nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-08 15:42:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: better local variables and contextual error messages

Browse Source
This commit is contained in:
ruthra kumar
2025-02-10 17:36:31 +05:30
parent 7791777d1a
commit 626b345caf
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/controllers/budget_controller.py
View File

@@ -4,6 +4,7 @@ import frappe
from frappe import _, qb from frappe import _, qb
from frappe.query_builder import Criterion from frappe.query_builder import Criterion
from frappe.query_builder.functions import IfNull, Sum from frappe.query_builder.functions import IfNull, Sum
from frappe.utils import get_link_to_form
from erpnext.accounts.utils import get_fiscal_year from erpnext.accounts.utils import get_fiscal_year
@@ -184,18 +185,20 @@ class BudgetValidation:
if requested_amount: if requested_amount:
self.to_validate[key]["requested_amount"] = requested_amount[0].amount self.to_validate[key]["requested_amount"] = requested_amount[0].amount
def stop_or_warn(self, validation_map): def stop_or_warn(self, v_map):
msg = [] msg = []
if validation_map.get("budget_doc").applicable_on_purchase_order and validation_map.get( budget = v_map.get("budget_doc")
"ordered_amount" if budget.applicable_on_purchase_order and v_map.get("ordered_amount") > v_map.get("budget_amount"):
) > validation_map.get("budget_amount"):
# TODO: handle monthly accumulation # TODO: handle monthly accumulation
# action_if_accumulated_monthly_budget_exceeded_on_po, # action_if_accumulated_monthly_budget_exceeded_on_po,
if validation_map.get("budget_doc").action_if_annual_budget_exceeded_on_po == "Warn": if budget.action_if_annual_budget_exceeded_on_po == "Warn":
msg.append("some warning message") msg.append("some warning message")
if validation_map.get("budget_doc").action_if_annual_budget_exceeded_on_po == "Stop": if budget.action_if_annual_budget_exceeded_on_po == "Stop":
frappe.throw("Booking gone above budget", BudgetExceededError, title=_("Budget Exceeded")) _msg = _(
"Expenses have gone above budget: {}".format(get_link_to_form("Budget", budget.name))
)
frappe.throw(_msg, BudgetExceededError, title=_("Budget Exceeded"))
def validate_for_overbooking(self): def validate_for_overbooking(self):
# TODO: Need to fetch historical amount and add them to the current document; GL effect is pending # TODO: Need to fetch historical amount and add them to the current document; GL effect is pending