diff --git a/erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py b/erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
index 9c391b7b3fb..8345a452c6c 100644
--- a/erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
+++ b/erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
@@ -707,86 +707,84 @@ def make_purchase_receipt(source_name, target_doc=None, save=False, submit=False
else:
source_doc = source_name
- if not source_doc.is_return:
- if not target_doc:
- target_doc = frappe.new_doc("Purchase Receipt")
- target_doc.is_subcontracted = 1
- target_doc.is_old_subcontracting_flow = 0
+ if source_doc.is_return:
+ return
- target_doc = get_mapped_doc(
- "Subcontracting Receipt",
- source_doc.name,
- {
- "Subcontracting Receipt": {
- "doctype": "Purchase Receipt",
- "field_map": {
- "posting_date": "posting_date",
- "posting_time": "posting_time",
- "name": "subcontracting_receipt",
- "supplier_warehouse": "supplier_warehouse",
- },
- "field_no_map": ["total_qty", "total"],
+ po_doc = frappe.get_doc("Purchase Order", source_doc.items[0].purchase_order)
+ target_doc = get_mapped_doc(
+ "Purchase Order",
+ po_doc.name,
+ {
+ "Purchase Order": {
+ "doctype": "Purchase Receipt",
+ "validation": {
+ "docstatus": ["=", 1],
},
+ "field_no_map": ["items"],
},
- target_doc,
- ignore_child_tables=True,
+ "Purchase Taxes and Charges": {"doctype": "Purchase Taxes and Charges", "reset_value": True},
+ },
+ )
+
+ target_doc.update(
+ {
+ "posting_date": source_doc.posting_date,
+ "posting_time": source_doc.posting_time,
+ "subcontracting_receipt": source_doc.name,
+ "supplier_warehouse": source_doc.supplier_warehouse,
+ "is_subcontracted": 1,
+ "is_old_subcontracting_flow": 0,
+ "currency": frappe.get_cached_value("Company", target_doc.company, "default_currency"),
+ }
+ )
+
+ po_items_details = {po_item.name: po_item for po_item in po_doc.items}
+
+ for item in source_doc.items:
+ if po_item := po_items_details.get(item.purchase_order_item):
+ conversion_factor = flt(po_item.qty) / flt(po_item.fg_item_qty)
+ item_row = {
+ "item_code": po_item.item_code,
+ "item_name": po_item.item_name,
+ "conversion_factor": conversion_factor,
+ "qty": flt(item.qty) * conversion_factor,
+ "rejected_qty": flt(item.rejected_qty) * conversion_factor,
+ "uom": po_item.uom,
+ "rate": po_item.rate,
+ "warehouse": item.warehouse,
+ "rejected_warehouse": item.rejected_warehouse,
+ "purchase_order": po_doc.name,
+ "purchase_order_item": item.purchase_order_item,
+ "subcontracting_receipt_item": item.name,
+ "project": po_item.project,
+ }
+ target_doc.append("items", item_row)
+
+ if not target_doc.items:
+ frappe.throw(
+ _("Purchase Order Item reference is missing in Subcontracting Receipt {0}").format(
+ source_doc.name
+ )
)
- target_doc.currency = frappe.get_cached_value("Company", target_doc.company, "default_currency")
+ target_doc.set_missing_values()
- po_items_details = {}
- for item in source_doc.items:
- if item.purchase_order and item.purchase_order_item:
- if item.purchase_order not in po_items_details:
- po_doc = frappe.get_doc("Purchase Order", item.purchase_order)
- po_items_details[item.purchase_order] = {
- po_item.name: po_item for po_item in po_doc.items
- }
+ if (save or submit) and frappe.has_permission(target_doc.doctype, "create"):
+ target_doc.save()
- if po_item := po_items_details[item.purchase_order].get(item.purchase_order_item):
- conversion_factor = flt(po_item.qty) / flt(po_item.fg_item_qty)
- item_row = {
- "item_code": po_item.item_code,
- "item_name": po_item.item_name,
- "conversion_factor": conversion_factor,
- "qty": flt(item.qty) * conversion_factor,
- "rejected_qty": flt(item.rejected_qty) * conversion_factor,
- "uom": po_item.uom,
- "rate": po_item.rate,
- "warehouse": item.warehouse,
- "rejected_warehouse": item.rejected_warehouse,
- "purchase_order": item.purchase_order,
- "purchase_order_item": item.purchase_order_item,
- "subcontracting_receipt_item": item.name,
- "project": po_item.project,
- }
- target_doc.append("items", item_row)
+ if submit and frappe.has_permission(target_doc.doctype, "submit", target_doc):
+ try:
+ target_doc.submit()
+ except Exception as e:
+ target_doc.add_comment("Comment", _("Submit Action Failed") + "
" + str(e))
- if not target_doc.items:
- frappe.throw(
- _("Purchase Order Item reference is missing in Subcontracting Receipt {0}").format(
- source_doc.name
- )
+ if notify:
+ frappe.msgprint(
+ _("Purchase Receipt {0} created.").format(
+ get_link_to_form(target_doc.doctype, target_doc.name)
+ ),
+ indicator="green",
+ alert=True,
)
- target_doc.set_missing_values()
-
- if (save or submit) and frappe.has_permission(target_doc.doctype, "create"):
- target_doc.save()
-
- if submit and frappe.has_permission(target_doc.doctype, "submit", target_doc):
- try:
- target_doc.submit()
- except Exception as e:
- target_doc.add_comment("Comment", _("Submit Action Failed") + "
" + str(e))
-
- if notify:
- frappe.msgprint(
- _("Purchase Receipt {0} created.").format(
- get_link_to_form(target_doc.doctype, target_doc.name)
- ),
- indicator="green",
- alert=True,
- )
-
- return target_doc
+ return target_doc