From 6004b66797fa9da9591060f154c45b5fbfd2fcbc Mon Sep 17 00:00:00 2001 From: Zarrar Date: Mon, 30 Jul 2018 10:57:13 +0530 Subject: [PATCH] [Minor] Job Offer UX improvise (#15042) * job offer ux improv * Update job_offer.js --- erpnext/hr/doctype/job_offer/job_offer.js | 11 ++++++++++- erpnext/hr/doctype/job_offer/job_offer.py | 4 +++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/job_offer/job_offer.js b/erpnext/hr/doctype/job_offer/job_offer.js index f90feaee1ee..367ce383186 100755 --- a/erpnext/hr/doctype/job_offer/job_offer.js +++ b/erpnext/hr/doctype/job_offer/job_offer.js @@ -13,13 +13,22 @@ frappe.ui.form.on("Job Offer", { }, refresh: function (frm) { - if ((!frm.doc.__islocal) && (frm.doc.status == 'Accepted') && (frm.doc.docstatus === 1)) { + if ((!frm.doc.__islocal) && (frm.doc.status == 'Accepted') + && (frm.doc.docstatus === 1) && (!frm.doc.__onload.employee)) { frm.add_custom_button(__('Make Employee'), function () { erpnext.job_offer.make_employee(frm); } ); } + + if(frm.doc.__onload.employee) { + frm.add_custom_button(__('Show Employee'), + function () { + frappe.set_route("Form", "Employee", frm.doc.__onload.employee); + } + ); + } } }); diff --git a/erpnext/hr/doctype/job_offer/job_offer.py b/erpnext/hr/doctype/job_offer/job_offer.py index 813b442c552..7e3014b38c8 100644 --- a/erpnext/hr/doctype/job_offer/job_offer.py +++ b/erpnext/hr/doctype/job_offer/job_offer.py @@ -7,7 +7,9 @@ from frappe.model.document import Document from frappe.model.mapper import get_mapped_doc class JobOffer(Document): - pass + def onload(self): + employee = frappe.db.get_value("Employee", {"job_applicant": self.job_applicant}, "name") or "" + self.set_onload("employee", employee) @frappe.whitelist() def make_employee(source_name, target_doc=None):