diff --git a/erpnext/accounts/doctype/sales_invoice/pos.py b/erpnext/accounts/doctype/sales_invoice/pos.py index 5ed25b432a2..c62088d79c8 100644 --- a/erpnext/accounts/doctype/sales_invoice/pos.py +++ b/erpnext/accounts/doctype/sales_invoice/pos.py @@ -63,7 +63,7 @@ def update_pos_profile_data(doc, pos_profile, company_data): doc.naming_series = pos_profile.get('naming_series') or 'SINV-' doc.letter_head = pos_profile.get('letter_head') or company_data.default_letter_head doc.ignore_pricing_rule = pos_profile.get('ignore_pricing_rule') or 0 - doc.apply_discount_on = pos_profile.get('apply_discount_on') or '' + doc.apply_discount_on = pos_profile.get('apply_discount_on') if pos_profile.get('apply_discount') else '' doc.customer_group = pos_profile.get('customer_group') or get_root('Customer Group') doc.territory = pos_profile.get('territory') or get_root('Territory') diff --git a/erpnext/accounts/general_ledger.py b/erpnext/accounts/general_ledger.py index 4af197e42c2..392902c935a 100644 --- a/erpnext/accounts/general_ledger.py +++ b/erpnext/accounts/general_ledger.py @@ -168,8 +168,8 @@ def delete_gl_entries(gl_entries=None, voucher_type=None, voucher_no=None, if not gl_entries: gl_entries = frappe.db.sql(""" - select account, posting_date, party_type, party, cost_center, fiscal_year, - voucher_type, voucher_no, against_voucher_type, against_voucher, cost_center + select account, posting_date, party_type, party, cost_center, fiscal_year,voucher_type, + voucher_no, against_voucher_type, against_voucher, cost_center, company from `tabGL Entry` where voucher_type=%s and voucher_no=%s""", (voucher_type, voucher_no), as_dict=True) diff --git a/erpnext/accounts/report/accounts_receivable/accounts_receivable.py b/erpnext/accounts/report/accounts_receivable/accounts_receivable.py index 1c994489a8b..f6e1629454e 100644 --- a/erpnext/accounts/report/accounts_receivable/accounts_receivable.py +++ b/erpnext/accounts/report/accounts_receivable/accounts_receivable.py @@ -93,9 +93,10 @@ class ReceivablePayableReport(object): data = [] for gle in self.get_entries_till(self.filters.report_date, args.get("party_type")): if self.is_receivable_or_payable(gle, dr_or_cr, future_vouchers): - outstanding_amount = self.get_outstanding_amount(gle, self.filters.report_date, dr_or_cr) + outstanding_amount = flt(self.get_outstanding_amount(gle, + self.filters.report_date, dr_or_cr), currency_precision) + if abs(outstanding_amount) > 0.1/10**currency_precision: - row = [gle.posting_date, gle.party] # customer / supplier name @@ -227,7 +228,7 @@ class ReceivablePayableReport(object): account_currency, remarks, {0} from `tabGL Entry` where docstatus < 2 and party_type=%s and (party is not null and party != '') {1} - group by voucher_type, voucher_no, against_voucher_type, against_voucher + group by voucher_type, voucher_no, against_voucher_type, against_voucher, party order by posting_date, party""" .format(select_fields, conditions), values, as_dict=True) diff --git a/erpnext/controllers/trends.py b/erpnext/controllers/trends.py index 080d7499aa0..d991c15b0dc 100644 --- a/erpnext/controllers/trends.py +++ b/erpnext/controllers/trends.py @@ -49,10 +49,10 @@ def get_data(filters, conditions): posting_date = 't1.posting_date' if conditions["based_on_select"] in ["t1.project,", "t2.project,"]: - cond = 'and '+ conditions["based_on_select"][:-1] +' IS Not NULL' + cond = ' and '+ conditions["based_on_select"][:-1] +' IS Not NULL' if conditions.get('trans') in ['Sales Order', 'Purchase Order']: - cond += "and t1.status != 'Closed'" + cond += " and t1.status != 'Closed'" year_start_date, year_end_date = frappe.db.get_value("Fiscal Year", filters.get('fiscal_year'), ["year_start_date", "year_end_date"]) diff --git a/erpnext/setup/doctype/sales_partner/sales_partner.js b/erpnext/setup/doctype/sales_partner/sales_partner.js index cb66b7f9cb2..143bf442d3d 100644 --- a/erpnext/setup/doctype/sales_partner/sales_partner.js +++ b/erpnext/setup/doctype/sales_partner/sales_partner.js @@ -12,9 +12,3 @@ cur_frm.cscript.refresh = function(doc,dt,dn){ erpnext.utils.render_address_and_contact(cur_frm); } } - -cur_frm.fields_dict['targets'].grid.get_field("item_group").get_query = function(doc, dt, dn) { - return{ - filters:{ 'is_group': 0 } - } -} diff --git a/erpnext/stock/doctype/material_request/material_request.py b/erpnext/stock/doctype/material_request/material_request.py index 0be2baee0cf..06df636cd73 100644 --- a/erpnext/stock/doctype/material_request/material_request.py +++ b/erpnext/stock/doctype/material_request/material_request.py @@ -75,7 +75,7 @@ class MaterialRequest(BuyingController): pc_obj = frappe.get_doc('Purchase Common') pc_obj.validate_for_items(self) - self.set_title() + # self.set_title() # self.validate_qty_against_so() diff --git a/erpnext/support/doctype/warranty_claim/warranty_claim.js b/erpnext/support/doctype/warranty_claim/warranty_claim.js index cf9d806fdd9..9fed265ed0d 100644 --- a/erpnext/support/doctype/warranty_claim/warranty_claim.js +++ b/erpnext/support/doctype/warranty_claim/warranty_claim.js @@ -37,7 +37,7 @@ $.extend(cur_frm.cscript, new erpnext.support.WarrantyClaim({frm: cur_frm})); cur_frm.cscript.onload = function(doc,cdt,cdn){ if(!doc.status) - set_multiple(dt,dn,{status:'Open'}); + set_multiple(cdt,cdn,{status:'Open'}); } cur_frm.fields_dict['customer_address'].get_query = function(doc, cdt, cdn) {