From 5e672990b3802a1a70b5bf7ed7b6fe352ebf823f Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 24 Jun 2025 12:42:34 +0530 Subject: [PATCH] fix: salvage value after value adjustment --- .../asset_value_adjustment/asset_value_adjustment.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py b/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py index d67ba06cfe0..11a63e86e55 100644 --- a/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py +++ b/erpnext/assets/doctype/asset_value_adjustment/asset_value_adjustment.py @@ -180,13 +180,22 @@ class AssetValueAdjustment(Document): if asset.calculate_depreciation: for row in asset.finance_books: if cstr(row.finance_book) == cstr(self.finance_book): - row.value_after_depreciation += flt(difference_amount) + salvage_value_adjustment = ( + self.get_adjusted_salvage_value_amount(row, difference_amount) or 0 + ) + row.expected_value_after_useful_life += salvage_value_adjustment + row.value_after_depreciation = row.value_after_depreciation + flt(difference_amount) row.db_update() asset.value_after_depreciation += flt(difference_amount) asset.db_update() return asset + def get_adjusted_salvage_value_amount(self, row, difference_amount): + if row.expected_value_after_useful_life: + salvage_value_adjustment = (difference_amount * row.salvage_value_percentage) / 100 + return flt(salvage_value_adjustment) + def get_adjustment_note(self): if self.docstatus == 1: notes = _(