nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 00:14:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(cache): fix active SLA doctype caching (#26861)

Browse Source 
If no SLA is configured then this query runs on EVERY `validate` call.

Root cause: if not active SLA doctypes exist then `not []` evalutes to
true and causes query to run again.
This commit is contained in:
Ankush
2021-08-09 22:15:49 +05:30
committed by GitHub
parent b92c404ed0
commit 5e428f0447
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@@ -281,15 +281,18 @@ def get_repeated(values):
def get_documents_with_active_service_level_agreement(): def get_documents_with_active_service_level_agreement():
if not frappe.cache().hget("service_level_agreement", "active"): sla_doctypes = frappe.cache().hget("service_level_agreement", "active")
set_documents_with_active_service_level_agreement()
return frappe.cache().hget("service_level_agreement", "active") if sla_doctypes is None:
return set_documents_with_active_service_level_agreement()
return sla_doctypes
def set_documents_with_active_service_level_agreement(): def set_documents_with_active_service_level_agreement():
active = [sla.document_type for sla in frappe.get_all("Service Level Agreement", fields=["document_type"])] active = [sla.document_type for sla in frappe.get_all("Service Level Agreement", fields=["document_type"])]
frappe.cache().hset("service_level_agreement", "active", active) frappe.cache().hset("service_level_agreement", "active", active)
return active
def apply(doc, method=None): def apply(doc, method=None):