nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 19:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor cleanups

Browse Source
This commit is contained in:
Nabin Hait
2017-11-06 17:38:44 +05:30
parent 271b7cd4f9
commit 5de499e5d5
2 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/accounts/report/sales_payment_summary/sales_payment_summary.js
View File

@@ -33,7 +33,8 @@ frappe.query_reports["Sales Payment Summary"] = {
"fieldname":"owner", "fieldname":"owner",
"label": __("Owner"), "label": __("Owner"),
"fieldtype": "Link", "fieldtype": "Link",
"options": "User" "options": "User",
"defaults": user
}, },
{ {
"fieldname":"cost_center", "fieldname":"cost_center",

28
erpnext/accounts/report/sales_payment_summary/sales_payment_summary.py
View File

@@ -6,14 +6,12 @@ import frappe
from frappe import _ from frappe import _
def execute(filters=None): def execute(filters=None):
columns, data = [], [] columns, data = [], []
columns=get_columns() columns=get_columns()
data=get_sales_payment_data(filters, columns) data=get_sales_payment_data(filters, columns)
return columns, data return columns, data
def get_columns(): def get_columns():
return [ return [
_("Date") + ":Date:80", _("Date") + ":Date:80",
_("Owner") + "::150", _("Owner") + "::150",
@@ -27,16 +25,16 @@ def get_columns():
] ]
def get_sales_payment_data(filters, columns): def get_sales_payment_data(filters, columns):
sales_invoice_data = get_sales_invoice_data(filters) sales_invoice_data = get_sales_invoice_data(filters)
data = [] data = []
for inv in sales_invoice_data: for inv in sales_invoice_data:
row = [inv.posting_date, inv.owner, inv.mode_of_payment,inv.warehouse, inv.cost_center,inv.net_total, inv.total_taxes, inv.paid_amount, inv.net_total + inv.total_taxes - inv.paid_amount] row = [inv.posting_date, inv.owner, inv.mode_of_payment,inv.warehouse,
inv.cost_center,inv.net_total, inv.total_taxes, inv.paid_amount,
(inv.net_total + inv.total_taxes - inv.paid_amount)]
data.append(row) data.append(row)
return data return data
def get_conditions(filters): def get_conditions(filters):
conditions = "" conditions = ""
if filters.get("company"): conditions += " a.company=%(company)s" if filters.get("company"): conditions += " a.company=%(company)s"
if filters.get("customer"): conditions += " and a.customer = %(customer)s" if filters.get("customer"): conditions += " and a.customer = %(customer)s"
@@ -51,10 +49,18 @@ def get_conditions(filters):
return conditions return conditions
def get_sales_invoice_data(filters): def get_sales_invoice_data(filters):
conditions = get_conditions(filters) conditions = get_conditions(filters)
return frappe.db.sql("""select a.owner, a.posting_date, c.mode_of_payment, b.warehouse, b.cost_center, return frappe.db.sql("""
sum(a.net_total) as "net_total",sum(a.total_taxes_and_charges) as "total_taxes", sum(a.base_paid_amount) as "paid_amount" select
from `tabSales Invoice` a, `tabSales Invoice Item` b, `tabSales Invoice Payment` c a.owner, a.posting_date, c.mode_of_payment, b.warehouse, b.cost_center,
where a.name = b.parent and a.name = c.parent and {conditions} sum(a.net_total) as "net_total",
group by a.owner, a.posting_date, c.mode_of_payment, b.warehouse, b.cost_center""".format(conditions=conditions),filters, as_dict=1) sum(a.total_taxes_and_charges) as "total_taxes",
sum(a.base_paid_amount) as "paid_amount"
from `tabSales Invoice` a, `tabSales Invoice Item` b, `tabSales Invoice Payment` c
where
a.name = b.parent
and a.name = c.parent
and {conditions}
group by
a.owner, a.posting_date, c.mode_of_payment, b.warehouse, b.cost_center
""".format(conditions=conditions), filters, as_dict=1)