From 2201fc62a290f15c3570043c832663d63d4ec6de Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 30 Oct 2024 00:25:18 +0530 Subject: [PATCH] fix: find first PCV to consider opening entries --- .../period_closing_voucher/period_closing_voucher.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py index 6ffa6346702..2a9b624a47a 100644 --- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py +++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py @@ -413,11 +413,16 @@ class PeriodClosingVoucher(AccountsController): return closing_entries def is_first_period_closing_voucher(self): - return not frappe.db.exists( + first_pcv = frappe.db.get_value( "Period Closing Voucher", - {"company": self.company, "docstatus": 1, "name": ("!=", self.name)}, + {"company": self.company, "docstatus": 1}, + "name", + order_by="period_end_date", ) + if not first_pcv or first_pcv == self.name: + return True + def cancel_gl_entries(self): if self.get_gle_count_against_current_pcv() > 5000: frappe.enqueue(