nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-03 05:28:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: handle exceptions when updating addresses (#22307) (#22316)

Browse Source 
* refactor: handle exceptions when updating addresses

* refactor: fold common statements in a loop

(cherry picked from commit 34d2bfbb3e)

Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2020-06-18 17:04:45 +05:30
committed by GitHub
parent 62882ea65b
commit 5bd479e8ee
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/erpnext_integrations/connectors/woocommerce_connection.py
View File

@@ -73,10 +73,16 @@ def link_customer_and_address(raw_billing_data, raw_shipping_data, customer_name
if customer_exists: if customer_exists:
frappe.rename_doc("Customer", old_name, customer_name) frappe.rename_doc("Customer", old_name, customer_name)
billing_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Billing"}) for address_type in ("Billing", "Shipping",):
shipping_address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": "Shipping"}) try:
rename_address(billing_address, customer) address = frappe.get_doc("Address", {"woocommerce_email": customer_woo_com_email, "address_type": address_type})
rename_address(shipping_address, customer) rename_address(address, customer)
except (
frappe.DoesNotExistError,
frappe.DuplicateEntryError,
frappe.ValidationError,
):
pass
else: else:
create_address(raw_billing_data, customer, "Billing") create_address(raw_billing_data, customer, "Billing")
create_address(raw_shipping_data, customer, "Shipping") create_address(raw_shipping_data, customer, "Shipping")