From a31075692c02b30f9442d29365247abdd0f2ba64 Mon Sep 17 00:00:00 2001 From: ljain112 Date: Mon, 21 Apr 2025 17:38:34 +0530 Subject: [PATCH] fix: set default company address in Sales Doctype on change of company --- .../doctype/sales_invoice/sales_invoice.js | 18 ------------- erpnext/public/js/utils/sales_common.js | 27 +++++++++++++++++++ .../doctype/sales_order/sales_order.js | 21 --------------- 3 files changed, 27 insertions(+), 39 deletions(-) diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js index c6fd7d0dbb5..191378a6488 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js @@ -778,24 +778,6 @@ frappe.ui.form.on("Sales Invoice", { }; }); }, - // When multiple companies are set up. in case company name is changed set default company address - company: function (frm) { - if (frm.doc.company) { - frappe.call({ - method: "erpnext.setup.doctype.company.company.get_default_company_address", - args: { name: frm.doc.company, existing_address: frm.doc.company_address || "" }, - debounce: 2000, - callback: function (r) { - if (r.message) { - frm.set_value("company_address", r.message); - } else { - frm.set_value("company_address", ""); - } - }, - }); - } - }, - onload: function (frm) { frm.redemption_conversion_factor = null; }, diff --git a/erpnext/public/js/utils/sales_common.js b/erpnext/public/js/utils/sales_common.js index be112a4ec46..ef0848f4949 100644 --- a/erpnext/public/js/utils/sales_common.js +++ b/erpnext/public/js/utils/sales_common.js @@ -115,6 +115,33 @@ erpnext.sales_common = { this.toggle_editable_price_list_rate(); } + company() { + super.company(); + this.set_default_company_address(); + } + + set_default_company_address() { + if (!frappe.meta.has_field(this.frm.doc.doctype, "company_address")) return; + var me = this; + if (this.frm.doc.company) { + frappe.call({ + method: "erpnext.setup.doctype.company.company.get_default_company_address", + args: { + name: this.frm.doc.company, + existing_address: this.frm.doc.company_address || "", + }, + debounce: 2000, + callback: function (r) { + if (r.message) { + me.frm.set_value("company_address", r.message); + } else { + me.frm.set_value("company_address", ""); + } + }, + }); + } + } + customer() { var me = this; erpnext.utils.get_party_details(this.frm, null, null, function () { diff --git a/erpnext/selling/doctype/sales_order/sales_order.js b/erpnext/selling/doctype/sales_order/sales_order.js index 911dad9e2d7..40734893066 100644 --- a/erpnext/selling/doctype/sales_order/sales_order.js +++ b/erpnext/selling/doctype/sales_order/sales_order.js @@ -164,27 +164,6 @@ frappe.ui.form.on("Sales Order", { ); }, - // When multiple companies are set up. in case company name is changed set default company address - company: function (frm) { - if (frm.doc.company) { - frappe.call({ - method: "erpnext.setup.doctype.company.company.get_default_company_address", - args: { - name: frm.doc.company, - existing_address: frm.doc.company_address || "", - }, - debounce: 2000, - callback: function (r) { - if (r.message) { - frm.set_value("company_address", r.message); - } else { - frm.set_value("company_address", ""); - } - }, - }); - } - }, - onload: function (frm) { if (!frm.doc.transaction_date) { frm.set_value("transaction_date", frappe.datetime.get_today());