From 5a5b49b61a2b79ddf34fc7b14c6aeec1a1513349 Mon Sep 17 00:00:00 2001 From: Sherin KR Date: Mon, 2 May 2022 15:03:30 +0530 Subject: [PATCH] fix: Period Closing Voucher is considering GL entries with is_cancelled=1 (#30865) * fix: Period Closing Voucher - Period Closing Voucher is considering GL entry with is_cancelled=1 as well * fix: condition Co-authored-by: Saqib Ansari --- .../doctype/period_closing_voucher/period_closing_voucher.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py index f66cf1c9f1a..53b1c64c460 100644 --- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py +++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py @@ -166,7 +166,7 @@ class PeriodClosingVoucher(AccountsController): sum(t1.debit_in_account_currency) - sum(t1.credit_in_account_currency) as bal_in_account_currency, sum(t1.debit) - sum(t1.credit) as bal_in_company_currency from `tabGL Entry` t1, `tabAccount` t2 - where t1.account = t2.name and t2.report_type = 'Profit and Loss' + where t1.is_cancelled = 0 and t1.account = t2.name and t2.report_type = 'Profit and Loss' and t2.docstatus < 2 and t2.company = %s and t1.posting_date between %s and %s group by t1.account, {dimension_fields}