From 57f5186dffdd9a027bc3d73769c62624e624bbce Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 22 Jun 2026 07:48:33 +0530 Subject: [PATCH] refactor(subcontracting): hoist ValueWrapper import to module level `validate_delivery_on_save` imported `pypika.terms.ValueWrapper` inside its per-item loop, re-running the import on every iteration. Move it to the module-level imports. --- erpnext/controllers/subcontracting_inward_controller.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/erpnext/controllers/subcontracting_inward_controller.py b/erpnext/controllers/subcontracting_inward_controller.py index e4f1ffdacff..92717975615 100644 --- a/erpnext/controllers/subcontracting_inward_controller.py +++ b/erpnext/controllers/subcontracting_inward_controller.py @@ -4,6 +4,7 @@ import frappe from frappe import _, bold from frappe.query_builder import Case from frappe.utils import flt, get_link_to_form +from pypika.terms import ValueWrapper from erpnext.stock.serial_batch_bundle import get_serial_batch_list_from_item @@ -500,8 +501,6 @@ class SubcontractingInwardController: ) ) - from pypika.terms import ValueWrapper - table = frappe.qb.DocType("Subcontracting Inward Order Item") query = ( frappe.qb.from_(table)