From 575fb43f9cd5852b37f1a3fe17db3206df596608 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 31 Dec 2024 20:33:05 +0530 Subject: [PATCH] fix: Fixed logic in if condition causing tests to fail --- erpnext/controllers/subcontracting_controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/controllers/subcontracting_controller.py b/erpnext/controllers/subcontracting_controller.py index 190dcc294bb..84a65160135 100644 --- a/erpnext/controllers/subcontracting_controller.py +++ b/erpnext/controllers/subcontracting_controller.py @@ -104,7 +104,7 @@ class SubcontractingController(StockController): ) if ( - not item.sc_conversion_factor + self.doctype == "Subcontracting Order" and not item.sc_conversion_factor ): # this condition will only be true if user has recently updated from develop branch service_item_qty = frappe.get_value( "Subcontracting Order Service Item",