nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-16 03:29:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix finance book getter error when book doesn't exist (#14987)

Browse Source
This commit is contained in:
Alchez
2018-07-23 14:16:35 +05:30
committed by Nabin Hait
parent 851ac754f7
commit 56bd5d8aaa
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/assets/doctype/asset/asset.py
View File

@@ -115,7 +115,7 @@ class Asset(AccountsController):
from_date = self.available_for_use_date from_date = self.available_for_use_date
if number_of_pending_depreciations: if number_of_pending_depreciations:
next_depr_date = getdate(add_months(self.available_for_use_date, next_depr_date = getdate(add_months(self.available_for_use_date,
number_of_pending_depreciations * 12)) number_of_pending_depreciations * 12))
if (cint(frappe.db.get_value("Asset Settings", None, "schedule_based_on_fiscal_year")) == 1 if (cint(frappe.db.get_value("Asset Settings", None, "schedule_based_on_fiscal_year")) == 1
and getdate(d.depreciation_start_date) < next_depr_date): and getdate(d.depreciation_start_date) < next_depr_date):
@@ -315,14 +315,14 @@ class Asset(AccountsController):
elif self.docstatus == 1: elif self.docstatus == 1:
status = "Submitted" status = "Submitted"
idx = self.get_default_finance_book_idx() or 0
expected_value_after_useful_life = self.finance_books[idx].expected_value_after_useful_life
value_after_depreciation = self.finance_books[idx].value_after_depreciation
if self.journal_entry_for_scrap: if self.journal_entry_for_scrap:
status = "Scrapped" status = "Scrapped"
elif self.finance_books: elif self.finance_books:
idx = self.get_default_finance_book_idx() or 0
expected_value_after_useful_life = self.finance_books[idx].expected_value_after_useful_life
value_after_depreciation = self.finance_books[idx].value_after_depreciation
if flt(value_after_depreciation) <= expected_value_after_useful_life: if flt(value_after_depreciation) <= expected_value_after_useful_life:
status = "Fully Depreciated" status = "Fully Depreciated"
elif flt(value_after_depreciation) < flt(self.gross_purchase_amount): elif flt(value_after_depreciation) < flt(self.gross_purchase_amount):