diff --git a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py index 039e1d2aa34..92674a146ba 100644 --- a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py +++ b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py @@ -55,6 +55,19 @@ class TestAccountingDimension(ERPNextTestSuite): dimension = frappe.get_doc({"doctype": "Accounting Dimension", "document_type": "Sales Team"}) self.assertRaises(frappe.ValidationError, dimension.insert) + def test_single_doctype_not_allowed_as_dimension(self): + dimension = frappe.get_doc({"doctype": "Accounting Dimension", "document_type": "Selling Settings"}) + self.assertRaises(frappe.ValidationError, dimension.insert) + + def test_non_scalar_dimension_value_skipped_in_gl_dict(self): + si = create_sales_invoice(do_not_save=1) + + si.department = "_Test Department - _TC" + self.assertEqual(si.get_gl_dict({}).get("department"), "_Test Department - _TC") + + si.department = ["_Test Department - _TC"] + self.assertNotIn("department", si.get_gl_dict({})) + def test_mandatory(self): location = frappe.get_doc("Accounting Dimension", "Location") location.dimension_defaults[0].mandatory_for_bs = True