nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 03:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add code to set batch no

Browse Source 
- And split item based on batch availibility
This commit is contained in:
Suraj Shetty
2019-07-30 09:02:03 +05:30
parent 9ad10cb425
commit 55ab31314c
1 changed files with 58 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
erpnext/stock/doctype/pick_ticket/pick_ticket.py
View File

@@ -14,13 +14,13 @@ class PickTicket(Document):
data = get_items_with_warehouse_and_quantity(item) data = get_items_with_warehouse_and_quantity(item)
for item_info in data: for item_info in data:
self.append('items', item_info) print(self.append('items', item_info))
for item in self.get('items'): for item_doc in self.get('items'):
if frappe.get_cached_value('Item', item.item, 'has_serial_no'): if frappe.get_cached_value('Item', item_doc.item, 'has_serial_no'):
set_serial_nos(item) set_serial_nos(item_doc)
elif frappe.get_cached_value('Item', item.item, 'has_batch_no'): elif frappe.get_cached_value('Item', item_doc.item, 'has_batch_no'):
set_batch_no(item, self) set_batch_no(item_doc, self)
def get_available_items(item): def get_available_items(item):
# gets all items available in different warehouses # gets all items available in different warehouses
@@ -56,22 +56,58 @@ def get_items_with_warehouse_and_quantity(item_doc):
return items return items
def set_serial_nos(item): def set_serial_nos(item_doc):
serial_nos = frappe.get_all('Serial No', { serial_nos = frappe.get_all('Serial No', {
'item_code': item.item, 'item_code': item_doc.item,
'warehouse': item.warehouse 'warehouse': item_doc.warehouse
}, limit=item.qty, order_by='purchase_date') }, limit=item_doc.qty, order_by='purchase_date')
item.set('serial_no', '\n'.join([serial_no.name for serial_no in serial_nos])) item_doc.set('serial_no', '\n'.join([serial_no.name for serial_no in serial_nos]))
def set_batch_no(item, doc): def set_batch_no(item_doc, parent_doc):
batches = frappe.get_all('Stock Ledger Entry', batches = frappe.db.sql("""
fields=['batch_no', 'sum(actual_qty) as qty'], SELECT
filters={ `batch_no`,
'item_code': item.item, SUM(`actual_qty`) AS `qty`
'warehouse': item.warehouse FROM
}, `tabStock Ledger Entry`
group_by='warehouse, batch_no, item_code') WHERE
`item_code`=%(item_code)s
AND `warehouse`=%(warehouse)s
GROUP BY
`warehouse`,
`batch_no`,
`item_code`
HAVING `qty` > 0
""", {
'item_code': item_doc.item,
'warehouse': item_doc.warehouse,
}, as_dict=1)
print(batches)
if batches: required_qty = item_doc.qty
# TODO: check expiry and split item if batch is more than 1 while required_qty > 0 and batches:
item.batch_no = batches[0].batch_no batch = batches.pop()
batch_expiry = frappe.get_value('Batch', batch.batch_no, 'expiry_date')
if batch_expiry and batch_expiry < frappe.utils.getdate():
print('---------- Batch {} is expired. Skipping... -------------'.format(batch.batch_no))
continue
item_doc.batch_no = batch.batch_no
required_qty -= batch.qty
if batch.qty >= item_doc.qty:
break
else:
# split item if quantity of item in batch is less that required
# Look for another batch
# set quantity of of item equal to batch quantity
item_doc.set('qty', batch.qty)
item_doc = parent_doc.append('items', {
'item': item_doc.item,
'qty': required_qty,
'warehouse': item_doc.warehouse,
'reference_doctype': item_doc.reference_doctype,
'reference_name': item_doc.reference_name
})
if required_qty:
print('---------- No batches found for {} qty of {}. Skipping... -------------'.format(required_qty, item_doc.item))
parent_doc.remove(item_doc)