nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-20 03:47:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56191 from diptanilsaha/fix/perms_on_whitelisted_functions

Browse Source 
fix: added missing permission validation on whitelisted function and removed unnecessary whitelisted decorator
This commit is contained in:
Diptanil Saha
2026-06-20 19:50:28 +05:30
committed by GitHub
parent bfffed0f52 e29535f29c
commit 5505ae43d4
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py
View File

@@ -626,6 +626,8 @@ def get_account_details(
party: str | None = None, party: str | None = None,
rounding_loss_allowance: float = 0.0, rounding_loss_allowance: float = 0.0,
): ):
frappe.has_permission("Account", doc=account, throw=True)
if not (company and posting_date): if not (company and posting_date):
frappe.throw(_("Company and Posting Date is mandatory")) frappe.throw(_("Company and Posting Date is mandatory"))

1
erpnext/accounts/report/utils.py
View File

@@ -146,7 +146,6 @@ def get_appropriate_company(filters):
return company return company
@frappe.whitelist()
def get_invoiced_item_gross_margin( def get_invoiced_item_gross_margin(
sales_invoice: str | None = None, sales_invoice: str | None = None,
item_code: str | None = None, item_code: str | None = None,