From 530f767098ec5769627e40d92a17e5f162901442 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 31 Mar 2022 14:37:30 +0530 Subject: [PATCH] revert: "fix: ignore circular dependencies on barcode scan" This reverts commit 98468fab18e08de440f2f6731759d221fe08c416. --- erpnext/public/js/controllers/transaction.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index 23c2bd405c1..61963925168 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -404,13 +404,11 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe } barcode(doc, cdt, cdn) { - const d = locals[cdt][cdn]; - if (!d.barcode) { + var d = locals[cdt][cdn]; + if(d.barcode=="" || d.barcode==null) { // barcode cleared, remove item d.item_code = ""; } - // flag required for circular triggers - d._triggerd_from_barcode = true; this.item_code(doc, cdt, cdn); } @@ -431,9 +429,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe this.frm.doc.doctype === 'Delivery Note') { show_batch_dialog = 1; } - if (!item._triggerd_from_barcode) { - item.barcode = null; - } + item.barcode = null; if(item.item_code || item.barcode || item.serial_no) {