Merge pull request #51664 from ruthra-kumar/reduce_tabs_in_accounts_settings

refactor: UI cleanup in Accounts settings and reports
This commit is contained in:
ruthra kumar
2026-01-11 19:02:27 +05:30
committed by GitHub
2 changed files with 31 additions and 27 deletions

View File

@@ -75,11 +75,6 @@
"ignore_account_closing_balance", "ignore_account_closing_balance",
"use_legacy_controller_for_pcv", "use_legacy_controller_for_pcv",
"column_break_25", "column_break_25",
"tab_break_dpet",
"show_balance_in_coa",
"banking_tab",
"enable_party_matching",
"enable_fuzzy_matching",
"reports_tab", "reports_tab",
"remarks_section", "remarks_section",
"general_ledger_remarks_length", "general_ledger_remarks_length",
@@ -92,9 +87,15 @@
"drop_ar_procedures", "drop_ar_procedures",
"legacy_section", "legacy_section",
"ignore_is_opening_check_for_reporting", "ignore_is_opening_check_for_reporting",
"payment_request_settings", "tab_break_dpet",
"chart_of_accounts_section",
"show_balance_in_coa",
"banking_section",
"enable_party_matching",
"enable_fuzzy_matching",
"payment_request_section",
"create_pr_in_draft_status", "create_pr_in_draft_status",
"budget_settings", "budget_section",
"use_legacy_budget_controller" "use_legacy_budget_controller"
], ],
"fields": [ "fields": [
@@ -342,7 +343,7 @@
{ {
"fieldname": "tab_break_dpet", "fieldname": "tab_break_dpet",
"fieldtype": "Tab Break", "fieldtype": "Tab Break",
"label": "Chart Of Accounts" "label": "Others"
}, },
{ {
"default": "1", "default": "1",
@@ -386,11 +387,6 @@
"fieldtype": "Check", "fieldtype": "Check",
"label": "Show Taxes as Table in Print" "label": "Show Taxes as Table in Print"
}, },
{
"fieldname": "banking_tab",
"fieldtype": "Tab Break",
"label": "Banking"
},
{ {
"default": "0", "default": "0",
"description": "Auto match and set the Party in Bank Transactions", "description": "Auto match and set the Party in Bank Transactions",
@@ -466,14 +462,9 @@
"fieldtype": "Check", "fieldtype": "Check",
"label": "Calculate daily depreciation using total days in depreciation period" "label": "Calculate daily depreciation using total days in depreciation period"
}, },
{
"description": "Payment Request created from Sales Order or Purchase Order will be in Draft status. When disabled document will be in unsaved state.",
"fieldname": "payment_request_settings",
"fieldtype": "Tab Break",
"label": "Payment Request"
},
{ {
"default": "1", "default": "1",
"description": "Payment Requests made from Sales / Purchase Invoice will be put in Draft explicitly",
"fieldname": "create_pr_in_draft_status", "fieldname": "create_pr_in_draft_status",
"fieldtype": "Check", "fieldtype": "Check",
"label": "Create in Draft Status" "label": "Create in Draft Status"
@@ -554,11 +545,6 @@
"label": "Role Allowed to Override Stop Action", "label": "Role Allowed to Override Stop Action",
"options": "Role" "options": "Role"
}, },
{
"fieldname": "budget_settings",
"fieldtype": "Tab Break",
"label": "Budget"
},
{ {
"default": "1", "default": "1",
"description": "If enabled, user will be alerted before resetting posting date to current date in relevant transactions", "description": "If enabled, user will be alerted before resetting posting date to current date in relevant transactions",
@@ -631,6 +617,26 @@
"fieldname": "default_ageing_range", "fieldname": "default_ageing_range",
"fieldtype": "Data", "fieldtype": "Data",
"label": "Default Ageing Range" "label": "Default Ageing Range"
},
{
"fieldname": "chart_of_accounts_section",
"fieldtype": "Section Break",
"label": "Chart Of Accounts"
},
{
"fieldname": "banking_section",
"fieldtype": "Section Break",
"label": "Banking"
},
{
"fieldname": "payment_request_section",
"fieldtype": "Section Break",
"label": "Payment Request"
},
{
"fieldname": "budget_section",
"fieldtype": "Section Break",
"label": "Budget"
} }
], ],
"grid_page_length": 50, "grid_page_length": 50,
@@ -640,7 +646,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2026-01-09 17:38:04.250917", "modified": "2026-01-11 18:30:45.968531",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Accounts", "module": "Accounts",
"name": "Accounts Settings", "name": "Accounts Settings",

View File

@@ -123,9 +123,7 @@ def get_report_summary(
return [ return [
{"value": net_income, "label": income_label, "datatype": "Currency", "currency": currency}, {"value": net_income, "label": income_label, "datatype": "Currency", "currency": currency},
{"type": "separator", "value": "-"},
{"value": net_expense, "label": expense_label, "datatype": "Currency", "currency": currency}, {"value": net_expense, "label": expense_label, "datatype": "Currency", "currency": currency},
{"type": "separator", "value": "=", "color": "blue"},
{ {
"value": net_profit, "value": net_profit,
"indicator": "Green" if net_profit > 0 else "Red", "indicator": "Green" if net_profit > 0 else "Red",