From c15e96c4607ec80a6ada1760c4b9a87d65e14735 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Sun, 11 Jan 2026 18:30:58 +0530 Subject: [PATCH 1/2] refactor: cleanup accounts settings --- .../accounts_settings/accounts_settings.json | 56 ++++++++++--------- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json index e68b1e58007..2b741136f96 100644 --- a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json +++ b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json @@ -75,11 +75,6 @@ "ignore_account_closing_balance", "use_legacy_controller_for_pcv", "column_break_25", - "tab_break_dpet", - "show_balance_in_coa", - "banking_tab", - "enable_party_matching", - "enable_fuzzy_matching", "reports_tab", "remarks_section", "general_ledger_remarks_length", @@ -92,9 +87,15 @@ "drop_ar_procedures", "legacy_section", "ignore_is_opening_check_for_reporting", - "payment_request_settings", + "tab_break_dpet", + "chart_of_accounts_section", + "show_balance_in_coa", + "banking_section", + "enable_party_matching", + "enable_fuzzy_matching", + "payment_request_section", "create_pr_in_draft_status", - "budget_settings", + "budget_section", "use_legacy_budget_controller" ], "fields": [ @@ -342,7 +343,7 @@ { "fieldname": "tab_break_dpet", "fieldtype": "Tab Break", - "label": "Chart Of Accounts" + "label": "Others" }, { "default": "1", @@ -386,11 +387,6 @@ "fieldtype": "Check", "label": "Show Taxes as Table in Print" }, - { - "fieldname": "banking_tab", - "fieldtype": "Tab Break", - "label": "Banking" - }, { "default": "0", "description": "Auto match and set the Party in Bank Transactions", @@ -466,14 +462,9 @@ "fieldtype": "Check", "label": "Calculate daily depreciation using total days in depreciation period" }, - { - "description": "Payment Request created from Sales Order or Purchase Order will be in Draft status. When disabled document will be in unsaved state.", - "fieldname": "payment_request_settings", - "fieldtype": "Tab Break", - "label": "Payment Request" - }, { "default": "1", + "description": "Payment Requests made from Sales / Purchase Invoice will be put in Draft explicitly", "fieldname": "create_pr_in_draft_status", "fieldtype": "Check", "label": "Create in Draft Status" @@ -554,11 +545,6 @@ "label": "Role Allowed to Override Stop Action", "options": "Role" }, - { - "fieldname": "budget_settings", - "fieldtype": "Tab Break", - "label": "Budget" - }, { "default": "1", "description": "If enabled, user will be alerted before resetting posting date to current date in relevant transactions", @@ -631,6 +617,26 @@ "fieldname": "default_ageing_range", "fieldtype": "Data", "label": "Default Ageing Range" + }, + { + "fieldname": "chart_of_accounts_section", + "fieldtype": "Section Break", + "label": "Chart Of Accounts" + }, + { + "fieldname": "banking_section", + "fieldtype": "Section Break", + "label": "Banking" + }, + { + "fieldname": "payment_request_section", + "fieldtype": "Section Break", + "label": "Payment Request" + }, + { + "fieldname": "budget_section", + "fieldtype": "Section Break", + "label": "Budget" } ], "grid_page_length": 50, @@ -640,7 +646,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2026-01-09 17:38:04.250917", + "modified": "2026-01-11 18:30:45.968531", "modified_by": "Administrator", "module": "Accounts", "name": "Accounts Settings", From e66b1a06f4d2c9e8ac03c4b1396e0281a3f71e1f Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Sun, 11 Jan 2026 18:38:23 +0530 Subject: [PATCH 2/2] refactor: remove redundant separators in P&L --- .../profit_and_loss_statement/profit_and_loss_statement.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/erpnext/accounts/report/profit_and_loss_statement/profit_and_loss_statement.py b/erpnext/accounts/report/profit_and_loss_statement/profit_and_loss_statement.py index b4280ca3067..c7585d9efd8 100644 --- a/erpnext/accounts/report/profit_and_loss_statement/profit_and_loss_statement.py +++ b/erpnext/accounts/report/profit_and_loss_statement/profit_and_loss_statement.py @@ -123,9 +123,7 @@ def get_report_summary( return [ {"value": net_income, "label": income_label, "datatype": "Currency", "currency": currency}, - {"type": "separator", "value": "-"}, {"value": net_expense, "label": expense_label, "datatype": "Currency", "currency": currency}, - {"type": "separator", "value": "=", "color": "blue"}, { "value": net_profit, "indicator": "Green" if net_profit > 0 else "Red",