From 515983e016f68c4ca8baf5ba5fd3d7807b5a8dcb Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Mon, 1 Jun 2026 02:32:36 +0530 Subject: [PATCH] fix: supplier status in list view --- erpnext/buying/doctype/supplier/supplier.py | 1 - erpnext/buying/doctype/supplier/supplier_list.js | 14 ++------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/erpnext/buying/doctype/supplier/supplier.py b/erpnext/buying/doctype/supplier/supplier.py index 9d640506a60..37d65c23a0d 100644 --- a/erpnext/buying/doctype/supplier/supplier.py +++ b/erpnext/buying/doctype/supplier/supplier.py @@ -88,7 +88,6 @@ class Supplier(TransactionBase): def before_save(self): if not self.on_hold: - self.hold_type = "" self.release_date = "" elif self.on_hold and not self.hold_type: self.hold_type = "All" diff --git a/erpnext/buying/doctype/supplier/supplier_list.js b/erpnext/buying/doctype/supplier/supplier_list.js index 6bf302ae0eb..0649e4c7fa5 100644 --- a/erpnext/buying/doctype/supplier/supplier_list.js +++ b/erpnext/buying/doctype/supplier/supplier_list.js @@ -1,13 +1,5 @@ frappe.listview_settings["Supplier"] = { - add_fields: [ - "supplier_name", - "supplier_group", - "image", - "on_hold", - "disabled", - "is_frozen", - "is_internal_supplier", - ], + add_fields: ["supplier_name", "supplier_group", "image", "on_hold", "disabled", "is_frozen"], get_indicator: function (doc) { if (cint(doc.disabled)) { return [__("Disabled"), "gray", "disabled,=,1"]; @@ -15,10 +7,8 @@ frappe.listview_settings["Supplier"] = { return [__("On Hold"), "red", "on_hold,=,1"]; } else if (cint(doc.is_frozen)) { return [__("Frozen"), "orange", "is_frozen,=,1"]; - } else if (cint(doc.is_internal_supplier)) { - return [__("Internal"), "blue", "is_internal_supplier,=,1"]; } else { - return [__("Active"), "green", "disabled,=,0|on_hold,=,0"]; + return [__("Active"), "green", "disabled,=,0|on_hold,=,0|is_frozen,=,0"]; } }, };