nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-21 07:38:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #54253 from frappe/mergify/bp/version-16-hotfix/pr-54190

Browse Source 
fix: add permission validation when prompting company details for incomplete letterhead data (backport #54190)
This commit is contained in:
Khushi Rawat
2026-04-13 15:58:05 +05:30
committed by GitHub
parent eb80a3704a f2450eaf60
commit 512a35a0ab
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
erpnext/controllers/accounts_controller.py
View File

@@ -4357,6 +4357,15 @@ def get_missing_company_details(doctype, docname):
address_display_list = get_address_display_list("Company", company)
address_line = address_display_list[0].get("address_line1") if address_display_list else ""
needs_new_company_address = not address_line
if needs_new_company_address and not frappe.has_permission("Address", "create", throw=False):
frappe.msgprint(
_(
"Company Address is missing. You don't have permission to create an Address. Please contact your System Manager."
)
)
return
required_fields.append(company_address)
required_fields.append(address_line)
@@ -4379,6 +4388,18 @@ def get_missing_company_details(doctype, docname):
def update_company_master_and_address(current_doctype, name, company, details):
from frappe.utils import validate_email_address
if not frappe.has_permission(current_doctype, "write", doc=name, throw=False):
frappe.throw(
_("You don't have permission to update this document. Please contact your System Manager."),
title=_("Insufficient Permissions"),
)
if not frappe.has_permission("Company", "write", doc=company, throw=False):
frappe.throw(
_("You don't have permission to update Company details. Please contact your System Manager."),
title=_("Insufficient Permissions"),
)
if isinstance(details, str):
details = frappe.parse_json(details)
@@ -4393,6 +4414,13 @@ def update_company_master_and_address(current_doctype, name, company, details):
company_address = details.get("company_address")
if details.get("address_line1"):
if not frappe.has_permission("Address", "create", throw=False):
frappe.throw(
_(
"You don't have permission to create a Company Address. Please contact your System Manager."
),
title=_("Insufficient Permissions"),
)
address_doc = frappe.get_doc(
{
"doctype": "Address",