nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-20 05:29:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: pos minor issues (#48384)

Browse Source 
* fix: remove tax rate on pos

* fix: use toggle components to load invoices

* refactor: remove resize selector
This commit is contained in:
Diptanil Saha
2025-07-03 22:50:23 +05:30
committed by GitHub
parent 5f721f01d3
commit 50bf4017d6
4 changed files with 4 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/selling/page/point_of_sale/pos_controller.js
View File

@@ -526,9 +526,7 @@ erpnext.PointOfSale.Controller = class {
() => this.make_invoice_frm(doc.doctype), () => this.make_invoice_frm(doc.doctype),
() => this.make_return_invoice(doc), () => this.make_return_invoice(doc),
() => this.cart.load_invoice(), () => this.cart.load_invoice(),
() => this.item_selector.toggle_component(true), () => this.toggle_components(true),
() => this.item_selector.resize_selector(false),
() => this.item_details.toggle_component(false),
() => frappe.dom.unfreeze(), () => frappe.dom.unfreeze(),
]); ]);
}); });
@@ -541,9 +539,7 @@ erpnext.PointOfSale.Controller = class {
() => this.frm.refresh(name), () => this.frm.refresh(name),
() => this.frm.call("reset_mode_of_payments"), () => this.frm.call("reset_mode_of_payments"),
() => this.cart.load_invoice(), () => this.cart.load_invoice(),
() => this.item_selector.toggle_component(true), () => this.toggle_components(true),
() => this.item_selector.resize_selector(false),
() => this.item_details.toggle_component(false),
]); ]);
}, },
delete_order: (doctype, name) => { delete_order: (doctype, name) => {

8
erpnext/selling/page/point_of_sale/pos_item_cart.js
View File

@@ -558,14 +558,8 @@ erpnext.PointOfSale.ItemCart = class {
const taxes_html = taxes const taxes_html = taxes
.map((t) => { .map((t) => {
if (t.tax_amount_after_discount_amount == 0.0) return; if (t.tax_amount_after_discount_amount == 0.0) return;
// if tax rate is 0, don't print it.
const description = /[0-9]+/.test(t.description)
? t.description
: t.rate != 0
? `${t.description} @ ${t.rate}%`
: t.description;
return `<div class="tax-row"> return `<div class="tax-row">
<div class="tax-label">${description}</div> <div class="tax-label">${t.description}</div>
<div class="tax-value">${format_currency(t.tax_amount_after_discount_amount, currency)}</div> <div class="tax-value">${format_currency(t.tax_amount_after_discount_amount, currency)}</div>
</div>`; </div>`;
}) })

22
erpnext/selling/page/point_of_sale/pos_item_selector.js
View File

@@ -367,28 +367,6 @@ erpnext.PointOfSale.ItemSelector = class {
this.set_search_value(""); this.set_search_value("");
} }
resize_selector(minimize) {
minimize
? this.$component
.find(".filter-section")
.css("grid-template-columns", "repeat(1, minmax(0, 1fr))")
: this.$component
.find(".filter-section")
.css("grid-template-columns", "repeat(12, minmax(0, 1fr))");
minimize
? this.$component.find(".search-field").css("margin", "var(--margin-sm) 0px")
: this.$component.find(".search-field").css("margin", "0px var(--margin-sm)");
minimize
? this.$component.css("grid-column", "span 2 / span 2")
: this.$component.css("grid-column", "span 6 / span 6");
minimize
? this.$items_container.css("grid-template-columns", "repeat(1, minmax(0, 1fr))")
: this.$items_container.css("grid-template-columns", "repeat(4, minmax(0, 1fr))");
}
toggle_component(show) { toggle_component(show) {
this.set_search_value(""); this.set_search_value("");
this.$component.css("display", show ? "flex" : "none"); this.$component.css("display", show ? "flex" : "none");

8
erpnext/selling/page/point_of_sale/pos_past_order_summary.js
View File

@@ -164,15 +164,9 @@ erpnext.PointOfSale.PastOrderSummary = class {
let taxes_html = doc.taxes let taxes_html = doc.taxes
.map((t) => { .map((t) => {
// if tax rate is 0, don't print it.
const description = /[0-9]+/.test(t.description)
? t.description
: t.rate != 0
? `${t.description} @ ${t.rate}%`
: t.description;
return ` return `
<div class="tax-row"> <div class="tax-row">
<div class="tax-label">${description}</div> <div class="tax-label">${t.description}</div>
<div class="tax-value">${format_currency(t.tax_amount_after_discount_amount, doc.currency)}</div> <div class="tax-value">${format_currency(t.tax_amount_after_discount_amount, doc.currency)}</div>
</div> </div>
`; `;