nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-30 03:58:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: test case

Browse Source 
(cherry picked from commit 3a78af7f42)
This commit is contained in:
nishkagosalia
2026-03-26 15:40:28 +05:30
committed by Mergify
parent d1a3571918
commit 5039f896bf
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/manufacturing/report/bom_stock_analysis/bom_stock_analysis.js
View File

@@ -45,9 +45,9 @@ frappe.query_reports["BOM Stock Analysis"] = {
} }
if (data && data.bold) { if (data && data.bold) {
if (column.fieldname === "description" || column.fieldname === "item_name") { if (column.fieldname === "description") {
const qty_to_make = frappe.query_report.get_filter_value("qty_to_make"); const qty_to_make = Number(frappe.query_report.get_filter_value("qty_to_make")) || 0;
const producible = parseFloat(value) || 0; const producible = Number(String(data.description ?? "").replace(/,/g, "")) || 0;
const colour = qty_to_make && producible < qty_to_make ? "red" : "green"; const colour = qty_to_make && producible < qty_to_make ? "red" : "green";
return `<b style="color: ${colour}">${value}</b>`; return `<b style="color: ${colour}">${value}</b>`;
} }

5
erpnext/manufacturing/report/bom_stock_analysis/bom_stock_analysis.py
View File

@@ -10,6 +10,7 @@ from pypika.terms import ExistsCriterion
def execute(filters=None): def execute(filters=None):
filters = filters or {}
if filters.get("qty_to_make"): if filters.get("qty_to_make"):
columns = get_columns_with_qty_to_make() columns = get_columns_with_qty_to_make()
data = get_data_with_qty_to_make(filters) data = get_data_with_qty_to_make(filters)
@@ -35,7 +36,7 @@ def get_data_with_qty_to_make(filters):
bom_data = get_bom_data(filters) bom_data = get_bom_data(filters)
manufacture_details = get_manufacturer_records() manufacture_details = get_manufacturer_records()
purchase_rates = batch_fetch_purchase_rates(bom_data) purchase_rates = batch_fetch_purchase_rates(bom_data)
qty_to_make = filters.get("qty_to_make") qty_to_make = flt(filters.get("qty_to_make"))
data = [] data = []
for row in bom_data: for row in bom_data:
@@ -203,7 +204,7 @@ def get_bom_data(filters):
bom_item.item_code, bom_item.item_code,
bom_item.description, bom_item.description,
bom_item.parent.as_("from_bom_no"), bom_item.parent.as_("from_bom_no"),
bom_item.qty_consumed_per_unit.as_("qty_per_unit"), Sum(bom_item.qty_consumed_per_unit).as_("qty_per_unit"),
IfNull(Sum(bin.actual_qty), 0).as_("actual_qty"), IfNull(Sum(bin.actual_qty), 0).as_("actual_qty"),
) )
.where((bom_item.parent == filters.get("bom")) & (bom_item.parenttype == "BOM")) .where((bom_item.parent == filters.get("bom")) & (bom_item.parenttype == "BOM"))

3
erpnext/manufacturing/report/test_reports.py
View File

@@ -21,8 +21,7 @@ class TestManufacturingReports(ERPNextTestSuite):
self.REPORT_FILTER_TEST_CASES: list[tuple[ReportName, ReportFilters]] = [ self.REPORT_FILTER_TEST_CASES: list[tuple[ReportName, ReportFilters]] = [
("BOM Explorer", {"bom": self.last_bom}), ("BOM Explorer", {"bom": self.last_bom}),
("BOM Operations Time", {}), ("BOM Operations Time", {}),
("BOM Stock Calculated", {"bom": self.last_bom, "qty_to_make": 2}), ("BOM Stock Analysis", {"bom": self.last_bom, "_optional": ["warehouse"]}),
("BOM Stock Report", {"bom": self.last_bom, "qty_to_produce": 2}),
("Cost of Poor Quality Report", {"item": "_Test Item", "serial_no": "00"}), ("Cost of Poor Quality Report", {"item": "_Test Item", "serial_no": "00"}),
("Downtime Analysis", {}), ("Downtime Analysis", {}),
( (