nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-18 02:55:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: rewrite user-facing messages in Projects module

Browse Source 
Conservative cleanup of frappe.throw/msgprint messages per the message style
guide; meaning, severity, and .format() arguments are unchanged:

- index bare {} placeholders as {0}/{1}/... so translators can reorder
- move f-strings / .format() / concatenation out of _() (they break gettext
  extraction and never translate)
- wrap translatable dynamic values (DocType/Select labels) in _()
- fix grammar and colloquialisms
- drop no-op _() wrapping runtime-built strings

Part of #53976.
This commit is contained in:
Mihir Kandoi
2026-06-25 16:21:35 +05:30
parent 7124e47490
commit 4efb43d977
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/projects/doctype/task/task.py
View File

@@ -144,7 +144,7 @@ class Task(NestedSet):
if frappe.db.get_value("Task", d.task, "status") not in ("Completed", "Cancelled"): if frappe.db.get_value("Task", d.task, "status") not in ("Completed", "Cancelled"):
frappe.throw( frappe.throw(
_( _(
"Cannot complete task {0} as its dependant task {1} are not completed / cancelled." "Cannot complete task {0} as its dependent task {1} is not completed / cancelled."
).format(frappe.bold(self.name), frappe.bold(d.task)) ).format(frappe.bold(self.name), frappe.bold(d.task))
) )
@@ -316,7 +316,7 @@ class Task(NestedSet):
def on_trash(self): def on_trash(self):
if check_if_child_exists(self.name): if check_if_child_exists(self.name):
throw(_("Child Task exists for this Task. You can not delete this Task.")) throw(_("Child Task exists for this Task. You cannot delete this Task."))
self.update_nsm_model() self.update_nsm_model()

2
erpnext/projects/doctype/timesheet_detail/timesheet_detail.py
View File

@@ -105,7 +105,7 @@ class TimesheetDetail(Document):
def validate_dates(self): def validate_dates(self):
"""Validate that to_time is not before from_time.""" """Validate that to_time is not before from_time."""
if self.from_time and self.to_time and time_diff_in_hours(self.to_time, self.from_time) < 0: if self.from_time and self.to_time and time_diff_in_hours(self.to_time, self.from_time) < 0:
frappe.throw(_("To Time cannot be before from date")) frappe.throw(_("To Time cannot be before From Time"))
def validate_parent_project(self, parent_project: str): def validate_parent_project(self, parent_project: str):
"""Validate that project is same as Timesheet's parent project.""" """Validate that project is same as Timesheet's parent project."""