From 4c6f33000b0fffceec54daa002ea84563548852f Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 3 Jun 2026 16:23:30 +0530 Subject: [PATCH] ci: silence false-positive semgrep findings on relocated code Both patterns are unchanged from develop but newly appear in the diff because the refactoring relocated them: - purchase_order/mapper.make_purchase_invoice_from_portal: portal flow needs commit before redirect (matches develop behaviour) - asset_repair.on_cancel: ignore_linked_doctypes is a runtime cancel flag, not a persisted field --- erpnext/assets/doctype/asset_repair/asset_repair.py | 2 +- erpnext/buying/doctype/purchase_order/mapper.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/assets/doctype/asset_repair/asset_repair.py b/erpnext/assets/doctype/asset_repair/asset_repair.py index eb2a5e68c59..e81d95348d4 100644 --- a/erpnext/assets/doctype/asset_repair/asset_repair.py +++ b/erpnext/assets/doctype/asset_repair/asset_repair.py @@ -218,7 +218,7 @@ class AssetRepair(AccountsController): def on_cancel(self): self.asset_doc = frappe.get_doc("Asset", self.asset) if self.get("capitalize_repair_cost"): - self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry") + self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry") # nosemgrep self.update_asset_value() self.make_gl_entries(cancel=True) self.set_increase_in_asset_life() diff --git a/erpnext/buying/doctype/purchase_order/mapper.py b/erpnext/buying/doctype/purchase_order/mapper.py index f02f4ddcc42..e379824f33f 100644 --- a/erpnext/buying/doctype/purchase_order/mapper.py +++ b/erpnext/buying/doctype/purchase_order/mapper.py @@ -115,7 +115,7 @@ def make_purchase_invoice_from_portal(purchase_order_name: str): frappe.throw(_("Not Permitted"), frappe.PermissionError) doc.save() if not frappe.in_test: - frappe.db.commit() + frappe.db.commit() # nosemgrep frappe.response["type"] = "redirect" frappe.response.location = "/purchase-invoices/" + doc.name