nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-31 10:49:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: validation in customer group

Browse Source 
(cherry picked from commit 4f9a228175)
This commit is contained in:
ruthra kumar
2024-06-10 20:06:21 +05:30
committed by Mergify
parent 78ad3f6cdc
commit 4bde345399
1 changed files with 47 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
erpnext/setup/doctype/customer_group/customer_group.py
View File

@@ -38,6 +38,53 @@ class CustomerGroup(NestedSet):
def validate(self): def validate(self):
if not self.parent_customer_group: if not self.parent_customer_group:
self.parent_customer_group = get_root_of("Customer Group") self.parent_customer_group = get_root_of("Customer Group")
self.validate_currency_for_receivable_and_advance_account()
def validate_currency_for_receivable_and_advance_account(self):
for x in self.accounts:
company_default_currency = frappe.get_cached_value("Company", x.company, "default_currency")
receivable_account_currency = None
advance_account_currency = None
if x.account:
receivable_account_currency = frappe.get_cached_value(
"Account", x.account, "account_currency"
)
if x.advance_account:
advance_account_currency = frappe.get_cached_value(
"Account", x.advance_account, "account_currency"
)
if receivable_account_currency and receivable_account_currency != company_default_currency:
frappe.throw(
_("Receivable Account: {0} must be in Company default currency: {1}").format(
frappe.bold(x.account),
frappe.bold(company_default_currency),
)
)
if advance_account_currency and advance_account_currency != company_default_currency:
frappe.throw(
_("Advance Account: {0} must be in Company default currency: {1}").format(
frappe.bold(x.advance_account), frappe.bold(company_default_currency)
)
)
if (
receivable_account_currency
and advance_account_currency
and receivable_account_currency != advance_account_currency
):
frappe.throw(
_(
"Both Receivable Account: {0} and Advance Account: {1} must be of same currency for company: {2}"
).format(
frappe.bold(x.account),
frappe.bold(x.advance_account),
frappe.bold(x.company),
)
)
def on_update(self): def on_update(self):
self.validate_name_with_customer() self.validate_name_with_customer()