nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-03 12:19:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: optimize asset location and custodian update logic to avoid multiple updates

Browse Source
This commit is contained in:
KerollesFathy
2025-09-10 19:01:14 +03:00
parent f4cdb49126
commit 4bc76be130
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/assets/doctype/asset_movement/asset_movement.py
View File

@@ -142,14 +142,18 @@ class AssetMovement(Document):
def update_asset_location_and_custodian(self, asset_id, location, employee): def update_asset_location_and_custodian(self, asset_id, location, employee):
asset = frappe.get_doc("Asset", asset_id) asset = frappe.get_doc("Asset", asset_id)
updates = {}
if employee and employee != asset.custodian: if employee and employee != asset.custodian:
frappe.db.set_value("Asset", asset_id, "custodian", employee) updates["custodian"] = employee
elif not employee and asset.custodian: elif not employee and asset.custodian:
frappe.db.set_value("Asset", asset_id, "custodian", None) updates["custodian"] = ""
if location and location != asset.location: if location and location != asset.location:
frappe.db.set_value("Asset", asset_id, "location", location) updates["location"] = location
if updates:
frappe.db.set_value("Asset", asset_id, updates)
def log_asset_activity(self, asset_id, location, employee): def log_asset_activity(self, asset_id, location, employee):
if location and employee: if location and employee: